Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix and optimise overload compatibility checking#14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 2 commits intopython:masterfromhauntsaninja:overload-compat
Nov 6, 2022

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninjahauntsaninja commentedNov 5, 2022•
edited
Loading

Discovered as part of#14017

@hauntsaninjahauntsaninja marked this pull request as draftNovember 5, 2022 23:44
@github-actions

This comment has been minimized.

@hauntsaninjahauntsaninja marked this pull request as ready for reviewNovember 6, 2022 00:24
previous_match_left_index=left_index
found_match=True
matched_overloads.add(left_index)
break
Copy link
CollaboratorAuthor

@hauntsaninjahauntsaninjaNov 6, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

adding the break here is the main functional change, everything in the second commit preserves behaviour

@hauntsaninjahauntsaninja changed the titleFix bug in overload compatibility checkingFix bug and optimise overload compatibility checkingNov 6, 2022
@hauntsaninjahauntsaninja changed the titleFix bug and optimise overload compatibility checkingFix and optimise overload compatibility checkingNov 6, 2022
@github-actions
Copy link
Contributor

According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninjahauntsaninja merged commit807da26 intopython:masterNov 6, 2022
@hauntsaninjahauntsaninja deleted the overload-compat branchNovember 6, 2022 01:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hauntsaninja@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp