Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Revert sum literal integer change#13961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 1 commit intopython:masterfromhauntsaninja:revert-sum
Oct 29, 2022

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninjahauntsaninja commentedOct 29, 2022•
edited
Loading

This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing to undo. Patching this in typeshed also feels weird, since there's a more general soundness issue. If a typevar has a bound or constraint, we might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)

robin-wayve reacted with rocket emoji
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird. If a typevar has abound or constraint, we might not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.
@hauntsaninja
Copy link
CollaboratorAuthor

cc@AlexWaygood , in case you have opinions

@AlexWaygood
Copy link
Member

cc@AlexWaygood , in case you have opinions

my opinion is that huge performance regressions are bad, feel free to go ahead 👍 :)

@hauntsaninja
Copy link
CollaboratorAuthor

hauntsaninja commentedOct 29, 2022•
edited
Loading

Lol, alleged performance regressions though :-) I meant more on the upstreaming the revert question

@hauntsaninja
Copy link
CollaboratorAuthor

hauntsaninja commentedOct 29, 2022•
edited
Loading

I also filedmicrosoft/pyright#4108 , so we'll see if Eric has a point of view

@github-actions
Copy link
Contributor

According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninjahauntsaninja merged commit5319fa3 intopython:masterOct 29, 2022
@hauntsaninjahauntsaninja deleted the revert-sum branchOctober 29, 2022 19:47
hauntsaninja added a commit that referenced this pull requestOct 29, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
hauntsaninja added a commit that referenced this pull requestOct 29, 2022
@AlexWaygood
Copy link
Member

I meant more on the upstreaming the revert question

Hah, I thought this was a PR to the typeshed repo when I posted my comment :)

The stub forsum has got quite a lot more complicated than it used to be over the course of many PRs during the last ~6 months or so. Some of those PRs were by me, some were by other people. In the end it seems like it's a surprisingly difficult function to write an accurate stub for, so maybe we'd be better off now if we hadn't had any of thosesum PRs. There's still a few open typeshed issues aboutsum that I don't really know how to fix, and that have been caused by some of the recent increases in complexity.

I filed the PR adding_LiteralInteger to one of thesum overloads in response to a user complaint, so if we revert that PR over at typeshed, we should probably reopen that issue as once-again-unsolved.

If thesum change did cause a massive performance regression, I'd be curious to know whether pyright hasLiteral algorithms with the same bad time complexity, and whether it's therefore facing similar performance issues on codebases that have heavy use ofsum. A performance regression on that scale is obviously completely unacceptable, so if it's happening to all type checkers, it definitely needs to be reverted over at typeshed.

@hauntsaninja
Copy link
CollaboratorAuthor

hauntsaninja commentedOct 29, 2022•
edited
Loading

Yeah, I guess in my mind there are two slightly different things at play here:

  1. The (alleged) performance issue. I'm assuming this is mypy specific. No one's provided a good minimal repro and I haven't had time to investigate, so there's actually not too much to go on. Hence my default would be to not make a change to typeshed for a mypy perf issue (unless e.g. some other typeshed demographic has a problem with it).

  2. The underlying soundness issue. This could conceivably be a thing fixed in mypy and pyright (although Eric closed as a won't fix for now). Although as I'm writing this, I realise that the solution I had in mind wouldn't work.

I'm currently thinking if I were to make a change to typeshed it might be pragmatic to changeIterable[bool | _LiteralInteger] toIterable[bool | Literal[0, 1]]. This has the following advantages:

  • Still fixes the original typeshed report / the way this most likely comes up in real world code
  • Removes a weird soundness cliff at 26
  • I anticipate that if we are able to repro the perf issue, that reducing the size of the union would fix. There are some places where large unions make mypy slow

@AlexWaygood
Copy link
Member

I'm currently thinking if I were to make a change to typeshed it might be pragmatic to changeIterable[bool | _LiteralInteger] toIterable[bool | Literal[0, 1]].

I'd be fine with that. The only reason I went with_LiteralInteger was because we already had the_PositiveInteger and_NegativeInteger aliases inbuiltins.pyi (so it was easy to do), and (forgetting that mypy has performance issues with largeLiterals), it seemed good to make theLiteral as large as possible in order to avoid false positives.

  • Removes a weird soundness cliff at 26

Though there's a certain symmetry here withpow(), which has an awkward "oops, now we infer everything asAny" cliff at 26 :))

@AlexWaygood
Copy link
Member

AlexWaygood commentedOct 30, 2022•
edited
Loading

I agree that the underlying soundness issue is a thing, and is a pain. I think it's come up a few other times as well (but Eric's also right that it's not avery common issue). No idea how we could fix it, though — we'd probably need to somehow formalise exactly when it's unsound to solve aTypeVar with aLiteral. Eric's probably right that this is maybe best discussed over at python/typing.

github-actionsbot pushed a commit that referenced this pull requestNov 1, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestNov 2, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestNov 15, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestDec 1, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestDec 15, 2022
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJan 1, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJan 15, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
AlexWaygood pushed a commit to AlexWaygood/mypy that referenced this pull requestFeb 3, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
hauntsaninja added a commit that referenced this pull requestFeb 3, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
koogoro pushed a commit to koogoro/mypy that referenced this pull requestFeb 15, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
koogoro pushed a commit to koogoro/mypy that referenced this pull requestFeb 17, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
hauntsaninja added a commit that referenced this pull requestFeb 17, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
koogoro pushed a commit to koogoro/mypy that referenced this pull requestFeb 18, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
AlexWaygood pushed a commit to AlexWaygood/mypy that referenced this pull requestMar 1, 2023
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestFeb 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestFeb 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
jhance pushed a commit to jhance/mypy that referenced this pull requestFeb 26, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestMar 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestMar 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
hauntsaninja added a commit that referenced this pull requestMar 16, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestApr 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestApr 2, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestApr 4, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestApr 16, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestMay 10, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestMay 19, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestMay 27, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJun 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestJun 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJun 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJul 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestJul 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestAug 4, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestAug 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
KevinRK29 pushed a commit to KevinRK29/mypy that referenced this pull requestAug 18, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestAug 31, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestSep 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestOct 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestOct 16, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestNov 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestNov 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
cdce8p pushed a commit to cdce8p/mypy that referenced this pull requestNov 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestDec 1, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
github-actionsbot pushed a commit that referenced this pull requestDec 15, 2025
This is allegedly causing large performance problems, see 13821typeshed/8231 had zero hits on mypy_primer, so it's not the worst thingto undo. Patching this in typeshed also feels weird, since there's amore general soundness issue. If a typevar has a bound or constraint, wemight not want to solve it to a Literal.If we can confirm the performance regression or fix the unsoundnesswithin mypy, I might pursue upstreaming this in typeshed.(Reminder: add this to the sync_typeshed script once merged)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hauntsaninja@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp