May 10, 2024 · Oct 24, 2021 · Oct 25, 2021 · Oct 27, 2021 · Oct 27, 2021 · Oct 27, 2021
diff --git a/mypy/error_formatter.py b/mypy/error_formatter.py
                "message": error.message,
                "hint": None if len(error.hints) == 0 else "\n".join(error.hints),
                "code": None if error.errorcode is None else error.errorcode.code,
                "is_note": error.is_note,
                "severity": error.severity,
            }
        )

diff --git a/mypy/errors.py b/mypy/errors.py
        column: int,
        message: str,
        errorcode: ErrorCode | None,
 is_note: bool = False,
 severity: Literal["error", "note"],
    ) -> None:
        self.file_path = file_path
        self.line = line
        self.column = column
        self.message = message
        self.errorcode = errorcode
        self.is_note =is_note
        self.severity =severity
        self.hints: list[str] = []


            error = latest_error_at_location.get(error_location)
            if error is None:
                # This is purely a note, with no error correlated to it
                error = MypyError(file_path, line, column, message, errorcode,is_note=True)
                error = MypyError(file_path, line, column, message, errorcode,severity="note")
                errors.append(error)
                continue

            error.hints.append(message)

        else:
            error = MypyError(file_path, line, column, message, errorcode)
            error = MypyError(file_path, line, column, message, errorcode, severity="error")
            errors.append(error)
            error_location = (file_path, line, column)
            latest_error_at_location[error_location] = error
diff --git a/test-data/unit/outputjson.test b/test-data/unit/outputjson.test

 foo(1)
 [out]
 {"file": "main", "line": 5, "column": 0, "message": "Too many arguments for \"foo\"", "hint": null, "code": "call-arg", "is_note":false}
 {"file": "main", "line": 5, "column": 0, "message": "Too many arguments for \"foo\"", "hint": null, "code": "call-arg", "severity":"error"}

 [case testOutputJsonWithHint]
 # flags: --output=json
 def bar() -> None: ...
 bar('42')
 [out]
 {"file": "main", "line": 12, "column": 12, "message": "Revealed type is \"Overload(def (), def (x: builtins.int))\"", "hint": null, "code": "misc", "is_note":true}
 {"file": "main", "line": 14, "column": 0, "message": "No overload variant of \"foo\" matches argument type \"str\"", "hint": "Possible overload variants:\n    def foo() -> None\n    def foo(x: int) -> None", "code": "call-overload", "is_note":false}
 {"file": "main", "line": 17, "column": 0, "message": "Too many arguments for \"bar\"", "hint": null, "code": "call-arg", "is_note":false}
 {"file": "main", "line": 12, "column": 12, "message": "Revealed type is \"Overload(def (), def (x: builtins.int))\"", "hint": null, "code": "misc", "severity":"note"}
 {"file": "main", "line": 14, "column": 0, "message": "No overload variant of \"foo\" matches argument type \"str\"", "hint": "Possible overload variants:\n    def foo() -> None\n    def foo(x: int) -> None", "code": "call-overload", "severity":"error"}
 {"file": "main", "line": 17, "column": 0, "message": "Too many arguments for \"bar\"", "hint": null, "code": "call-arg", "severity":"error"}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,7 +29,7 @@ def report_error(self, error: "MypyError") -> str:
		"message": error.message,
		"hint": None if len(error.hints) == 0 else "\n".join(error.hints),
		"code": None if error.errorcode is None else error.errorcode.code,
		"is_note": error.is_note,
		"severity": error.severity,
		}
		)
Copy link Member ilevkivskyiApr 27, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This module should define a dictionary`str -> ErrorFormatter` that can be used in`build.py`. tusharsadhwani and mikeyatmixpanel reacted with thumbs up emoji

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1296,14 +1296,14 @@ def __init__(
		column: int,
		message: str,
		errorcode: ErrorCode \| None,
		is_note: bool = False,
		severity: Literal["error", "note"],
		) -> None:
		self.file_path = file_path
		self.line = line
		self.column = column
		self.message = message
		self.errorcode = errorcode
		self.is_note =is_note
		self.severity =severity
		self.hints: list[str] = []


Expand All		@@ -1326,14 +1326,14 @@ def create_errors(error_tuples: list[ErrorTuple]) -> list[MypyError]:
		error = latest_error_at_location.get(error_location)
		if error is None:
		# This is purely a note, with no error correlated to it
		error = MypyError(file_path, line, column, message, errorcode,is_note=True)
		error = MypyError(file_path, line, column, message, errorcode,severity="note")
		errors.append(error)
		continue

		error.hints.append(message)

		else:
		error = MypyError(file_path, line, column, message, errorcode)
		error = MypyError(file_path, line, column, message, errorcode, severity="error")
		errors.append(error)
		error_location = (file_path, line, column)
		latest_error_at_location[error_location] = error
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,7 +18,7 @@ def foo() -> None:

		foo(1)
		[out]
		{"file": "main", "line": 5, "column": 0, "message": "Too many arguments for \"foo\"", "hint": null, "code": "call-arg", "is_note":false}
		{"file": "main", "line": 5, "column": 0, "message": "Too many arguments for \"foo\"", "hint": null, "code": "call-arg", "severity":"error"}

		[case testOutputJsonWithHint]
		# flags: --output=json
Expand All		@@ -39,6 +39,6 @@ foo('42')
		def bar() -> None: ...
		bar('42')
Copy link Member JelleZijlstraMay 9, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Add a test case with`reveal_type()`; let's make sure that shows up in the output. tusharsadhwani reacted with thumbs up emoji
		[out]
		{"file": "main", "line": 12, "column": 12, "message": "Revealed type is \"Overload(def (), def (x: builtins.int))\"", "hint": null, "code": "misc", "is_note":true}
		{"file": "main", "line": 14, "column": 0, "message": "No overload variant of \"foo\" matches argument type \"str\"", "hint": "Possible overload variants:\n def foo() -> None\n def foo(x: int) -> None", "code": "call-overload", "is_note":false}
		{"file": "main", "line": 17, "column": 0, "message": "Too many arguments for \"bar\"", "hint": null, "code": "call-arg", "is_note":false}
		{"file": "main", "line": 12, "column": 12, "message": "Revealed type is \"Overload(def (), def (x: builtins.int))\"", "hint": null, "code": "misc", "severity":"note"}
		{"file": "main", "line": 14, "column": 0, "message": "No overload variant of \"foo\" matches argument type \"str\"", "hint": "Possible overload variants:\n def foo() -> None\n def foo(x: int) -> None", "code": "call-overload", "severity":"error"}
		{"file": "main", "line": 17, "column": 0, "message": "Too many arguments for \"bar\"", "hint": null, "code": "call-arg", "severity":"error"}