Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.9k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:python/mypy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:33d1eed
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:python/mypy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:ea8aacd
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 3commits
- 8files changed
- 1contributor
Commits on May 8, 2025
Consolidate descriptor handling in checkmember.py (#18831)
This is not a pure refactoring, but almost. Right now we are in a weirdsituation where we have two inconsistencies:* `__set__()` is handled in `checker.py` while `__get__()` is handled in`checkmember.py`* rules for when to use binder are slightly different betweendescriptors and settable properties.This PR fixes these two things. As a nice bonus we should get freesupport for unions in `__set__()`.
Local forward refs should precede global forward refs (#19000)
Fixes#18988This should be a minimal change to restore backwards compatibility foran edge case with forward references.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 33d1eed...ea8aacd
Uh oh!
There was an error while loading.Please reload this page.