Commitc2a82b9

authored

Do not emit unreachable warnings for lines that returnNotImplemented. (#20083)

I think no one has complained so far. I just encountered this (in myunderstanding) lack in `TypeChecker.is_noop_for_reachability` working on#20068.

1 parent80d0066 commitc2a82b9Copy full SHA for c2a82b9

File tree

+23

-1

lines changed

+23

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3147,6 +3147,8 @@ def is_noop_for_reachability(self, s: Statement) -> bool:`
`3147`	`3147`	`"""`
`3148`	`3148`	`ifisinstance(s,AssertStmt)andis_false_literal(s.expr):`
`3149`	`3149`	`returnTrue`
	`3150`	`+elifisinstance(s,ReturnStmt)andis_literal_not_implemented(s.expr):`
	`3151`	`+returnTrue`
`3150`	`3152`	`elifisinstance(s, (RaiseStmt,PassStmt)):`
`3151`	`3153`	`returnTrue`
`3152`	`3154`	`elifisinstance(s,ExpressionStmt):`
`@@ -8281,7 +8283,7 @@ def is_literal_none(n: Expression) -> bool:`
`8281`	`8283`	`returnisinstance(n,NameExpr)andn.fullname=="builtins.None"`
`8282`	`8284`
`8283`	`8285`
`8284`		`-defis_literal_not_implemented(n:Expression)->bool:`
	`8286`	`+defis_literal_not_implemented(n:Expression\|None)->bool:`
`8285`	`8287`	`returnisinstance(n,NameExpr)andn.fullname=="builtins.NotImplemented"`
`8286`	`8288`
`8287`	`8289`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1620,6 +1620,26 @@ reveal_type(bar().attr) # N: Revealed type is "Never"`
`1620`	`1620`	`reveal_type(foo().attr) # N: Revealed type is "Never"`
`1621`	`1621`	`1 # E: Statement is unreachable`
`1622`	`1622`
	`1623`	`+[case testIgnoreReturningNotImplemented]`
	`1624`	`+# flags: --warn-unreachable`
	`1625`	`+`
	`1626`	`+class C:`
	`1627`	`+ def __add__(self, o: C) -> C:`
	`1628`	`+ if not isinstance(o, C):`
	`1629`	`+ return NotImplemented`
	`1630`	`+ return C()`
	`1631`	`+ def __sub__(self, o: C) -> C:`
	`1632`	`+ if isinstance(o, C):`
	`1633`	`+ return C()`
	`1634`	`+ return NotImplemented`
	`1635`	`+ def __mul__(self, o: C) -> C:`
	`1636`	`+ if isinstance(o, C):`
	`1637`	`+ return C()`
	`1638`	`+ else:`
	`1639`	`+ return NotImplemented`
	`1640`	`+`
	`1641`	`+[builtins fixtures/isinstance.pyi]`
	`1642`	`+`
`1623`	`1643`	`[case testUnreachableStatementPrettyHighlighting]`
`1624`	`1644`	`# flags: --warn-unreachable --pretty`
`1625`	`1645`	`def x() -> None:`

Comments

(0)