Commit7d805b3

authored and

committed

Unwrap TypedDict item types before storing (#17640)

Fixes#17604Fixes#17608Fix is trivial, rectify an obvious omission in my original PR.(cherry picked from commitb56f357)

1 parent32675dd commit7d805b3Copy full SHA for 7d805b3

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,9 @@ def analyze_typeddict_classdef_fields(`
`323`	`323`	`returnNone, [], [],set()# Need to defer`
`324`	`324`	`types.append(analyzed)`
`325`	`325`	`ifnothas_placeholder(analyzed):`
`326`		`-stmt.type=analyzed`
	`326`	`+stmt.type= (`
	`327`	`+analyzed.itemifisinstance(analyzed,RequiredType)elseanalyzed`
	`328`	`+ )`
`327`	`329`	`# ...despite possible minor failures that allow further analysis.`
`328`	`330`	`ifstmt.typeisNoneorhasattr(stmt,"new_syntax")andnotstmt.new_syntax:`
`329`	`331`	`self.fail(TPDICT_CLASS_ERROR,stmt)`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2382,6 +2382,14 @@ class ForceDeferredEval: pass`
`2382`	`2382`	`[builtins fixtures/dict.pyi]`
`2383`	`2383`	`[typing fixtures/typing-typeddict.pyi]`
`2384`	`2384`
	`2385`	`+[case testTypedDictRequiredUnimportedAny]`
	`2386`	`+# flags: --disallow-any-unimported`
	`2387`	`+from typing import NotRequired, TypedDict`
	`2388`	`+from nonexistent import Foo # type: ignore[import-not-found]`
	`2389`	`+class Bar(TypedDict):`
	`2390`	`+ foo: NotRequired[Foo] # E: Type of variable becomes "Any" due to an unfollowed import`
	`2391`	`+[typing fixtures/typing-typeddict.pyi]`
	`2392`	`+`
`2385`	`2393`	`-- Required[]`
`2386`	`2394`
`2387`	`2395`	`[case testDoesRecognizeRequiredInTypedDictWithClass]`

Comments

(0)