NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

Commit50717cf

authored

Improve misleading message in Enum() (#5317) (#14590)

Clarifying this is a mypy limitation, not an Enum() requirementNot a true fix, but a workaround for#5317 to avoid confusion (as seenby the many duplicates)

1 parent0929773 commit50717cfCopy full SHA for 50717cf

File tree

2 files changed

-6

lines changed

mypy
- semanal_enum.py
test-data/unit
- check-enum.test

2 files changed

-6

lines changed

`‎mypy/semanal_enum.py‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -220,14 +220,14 @@ def parse_enum_call_args(`
`220`	`220`	`items.append(field)`
`221`	`221`	`else:`
`222`	`222`	`returnself.fail_enum_call_arg(`
`223`		`-"%s()expects a string, tuple, list or dict literalas the second argument"`
	`223`	`+"Second argument of%s()must be string, tuple, list or dict literalfor mypy to determine Enum members"`
`224`	`224`	`%class_name,`
`225`	`225`	`call,`
`226`	`226`	`)`
`227`	`227`	`else:`
`228`	`228`	`# TODO: Allow dict(x=1, y=2) as a substitute for {'x': 1, 'y': 2}?`
`229`	`229`	`returnself.fail_enum_call_arg(`
`230`		`-"%s()expects a string, tuple, list or dict literalas the second argument"`
	`230`	`+"Second argument of%s()must be string, tuple, list or dict literalfor mypy to determine Enum members"`
`231`	`231`	`%class_name,`
`232`	`232`	`call,`
`233`	`233`	`)`

`‎test-data/unit/check-enum.test‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -482,13 +482,13 @@ W.c`
`482`	`482`	`[typing fixtures/typing-medium.pyi]`
`483`	`483`	`[out]`
`484`	`484`	`main:2: error: Too few arguments for Enum()`
`485`		`-main:3: error: Enum()expects a string, tuple, list or dict literalas the second argument`
	`485`	`+main:3: error:Second argument ofEnum()must be string, tuple, list or dict literalfor mypy to determine Enum members`
`486`	`486`	`main:4: error: Too many arguments for Enum()`
`487`		`-main:5: error: Enum()expects a string, tuple, list or dict literalas the second argument`
	`487`	`+main:5: error:Second argument ofEnum()must be string, tuple, list or dict literalfor mypy to determine Enum members`
`488`	`488`	`main:5: error: Name "foo" is not defined`
`489`		`-main:7: error: Enum()expects a string, tuple, list or dict literalas the second argument`
	`489`	`+main:7: error:Second argument ofEnum()must be string, tuple, list or dict literalfor mypy to determine Enum members`
`490`	`490`	`main:8: error: Too few arguments for IntEnum()`
`491`		`-main:9: error: IntEnum()expects a string, tuple, list or dict literalas the second argument`
	`491`	`+main:9: error:Second argument ofIntEnum()must be string, tuple, list or dict literalfor mypy to determine Enum members`
`492`	`492`	`main:10: error: Too many arguments for IntEnum()`
`493`	`493`	`main:11: error: Enum() needs at least one item`
`494`	`494`	`main:12: error: Enum() needs at least one item`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit50717cf

File tree

2 files changed

2 files changed

`‎mypy/semanal_enum.py‎`

`‎test-data/unit/check-enum.test‎`

0 commit comments