Commit13f35ad

authored

Fix crash related to propagating type narrowing to nested functions (#15181)

1 parentd17b3ed commit13f35adCopy full SHA for 13f35ad

File tree

+15

-0

lines changed

+15

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1222,6 +1222,7 @@ def check_func_def(`
`1222`	`1222`	`ifnew_frameisNone:`
`1223`	`1223`	`new_frame=self.binder.push_frame()`
`1224`	`1224`	`new_frame.types[key]=narrowed_type`
	`1225`	`+self.binder.declarations[key]=old_binder.declarations[key]`
`1225`	`1226`	`withself.scope.push_function(defn):`
`1226`	`1227`	`# We suppress reachability warnings when we use TypeVars with value`
`1227`	`1228`	`# restrictions: we only want to report a warning if a certain statement is`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1329,3 +1329,17 @@ def narrow_with_multi_assign_3(x: Optional[str]) -> None:`
`1329`	`1329`	`y, x = None, None`
`1330`	`1330`
`1331`	`1331`	`[builtins fixtures/isinstance.pyi]`
	`1332`	`+`
	`1333`	`+[case testNestedFunctionSpecialCase]`
	`1334`	`+class C:`
	`1335`	`+ def __enter__(self, *args): ...`
	`1336`	`+ def __exit__(self, *args) -> bool: ...`
	`1337`	`+`
	`1338`	`+def f(x: object) -> None:`
	`1339`	`+ if x is not None:`
	`1340`	`+ pass`
	`1341`	`+`
	`1342`	`+ def nested() -> None:`
	`1343`	`+ with C():`
	`1344`	`+ pass`
	`1345`	`+[builtins fixtures/tuple.pyi]`

Comments

(0)