Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork48
readers: add MultiplexedPath.paths#310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 commentedJun 26, 2024
@jaraco what do you think of this? |
jaraco left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems reasonable to me. We should add some tests to ensure the use-case is covered. And should we include type annotations?
| @property | ||
| defpaths(self): | ||
| returnself._paths.copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we type-annotate this property to be a non-mutable Sequence, and becauseself._paths is not mutated internally (also treated like a non-mutable Sequence), there's no need to make a copy. But I'm okay either way.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#309