Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork48
Add missing tests and some minor fixes#200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FFY00 commentedOct 24, 2020
This should bring coverage back up to 100% 😊 |
…rrorMultiplexedPath can never be a file, so we can never open or read fromit.Signed-off-by: Filipe Laíns <lains@archlinux.org>
d5a5827 tofad2bf4CompareSigned-off-by: Filipe Laíns <lains@archlinux.org>
set() does not guarantee that the order will be keept, replace it withlist(OrderedDict.fromkeys(my_list)) which should honor it.Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Filipe Laíns <lains@archlinux.org>
…thon 2Signed-off-by: Filipe Laíns <lains@archlinux.org>
jaraco left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good to me. Thanks for pressing forward with this effort and working out the kinks. I've granted you access to the repo, so you should be able to merge your own request.
Would you also like to cut the release? It's simple, just update changelog.rst (you can do that in this PR), and then push an annotated tag (i.e.git tag -m tag v3.2.1) on the merge commit.
FFY00 commentedOct 28, 2020
I mean, sure. I can do that. |
There is some info in some of the commit messages, look at them if you are missing context.