Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork93
meta: add SimplePath protocol for PathDistribution#315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5f23a8a tod0616a8CompareThis is needed to properly annotate code that uses PathDistribution,otherwise I need to keep redefining the protocol in my code.Signed-off-by: Filipe Laíns <lains@riseup.net>
d0616a8 tofa20a0aCompareSigned-off-by: Filipe Laíns <lains@riseup.net>
… to easily distinguish. Add changelog.
MemberAuthor
FFY00 commentedMay 26, 2021
Please ping me when this goes to CPython, so that I can send a PR to typeshed. |
Member
jaraco commentedMay 26, 2021
I don't understand the diffcov failure. It says: It indicates thatline 26 is not covered andline 786 is not covered. But those lines should be executed on import. |
Member
jaraco commentedMay 26, 2021
I just ignored the spurious diffcov failure. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to properly annotate code that uses PathDistribution,
otherwise I need to keep redefining the protocol in my code.
Signed-off-by: Filipe Laínslains@riseup.net