Defer import of zipp#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jaraco merged 3 commits intopython:mainfromdanielhollas:defer-zipp

Sep 11, 2024

Merged

Defer import of zipp#502

jaraco merged 3 commits intopython:mainfromdanielhollas:defer-zipp

Sep 11, 2024

+4 −2

Conversation

Copy link

Contributor

danielhollas commentedAug 27, 2024

Impoting zipp takes between 2-4 ms on my machine, which is at least 10% of overall import time of theimportlib_metadata package (depending on Python version). Since this package is only used in a single code path it makes sense to defer it.

To estimate the cost of repeatedly callingimport zipp I ran

❯python -m timeit -s"import zipp""import zipp"5000000 loops, best of 5: 59.9 nsec per loop

(this is with cpython main branch)

Since this is in a codepath that reads a zipfile from disk, this overhead is negligible.

Defer import of zipp

76eebe0

This was referencedAug 27, 2024

Defer import of json and platform#503

Merged

Improve import time of various stdlib modulespython/cpython#118761

Closed

Copy link

Member

jaraco commentedSep 11, 2024•
edited
Loading

I'm starting to feel like a frog being slowly boiled. I'm seeing repeated optimizations like this being handled piecemeal, and each time I do, I need to go through the same process: point out that there's a systemic problem that hasno solution, ensure there's a comment protecting the change and linking to the motivation, then merge and roll out the change. </rant>

Looks good. I'll add the comment linking back to the motivation and analysis (here). Thanks for the contrib.