Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork93
metadata: remove Distribution._local#354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Importing an external module is anti-pattern and very unexpectedbehavior. Furthermore, the specific builder implementation we are usingwill provision an isolated virtual environmnent and perform the buildthere, which is unwanted in various scenarious.Perhaps there was a time this helper was needed, but we can nowremove this in favor of build.util.project_wheel_metadata[1].[1]https://github.com/pypa/build/blob/82051d509a87124a46f3766134c11fc8aee9b86a/src/build/util.py#L27Signed-off-by: Filipe Laíns <lains@riseup.net>
b5c483a toff1bb2eComparejaraco commentedNov 14, 2021
Unfortunately, it doesn't look like Also a bit of a nitpick, but I don't see how "wheel" is relevant to all of these functions. A wheel isn't generated; only the project metadata. I'd like to see a function that doesn't involve irrelevant words like |
FFY00 commentedNov 14, 2021
We can introduce further helpers to make that possible.
It is the metadata that is generated for the wheel. The name comes from PEP 517. https://www.python.org/dev/peps/pep-0517/#prepare-metadata-for-build-wheel A wheel is actually generated as a fallback if the backend does not implement the metadata hook, as recommended. sdists also contain metadata, which may be different from the wheel, and there is no guarantee that further binary formats that may be introduced in the future must have the same metadata as the wheel. I know I am being a bit conservative about the naming and origin of the data, but I didn't feel like it containing "wheel" in the name really hurt anything. Maybe I am an outlier, but my first questing after seeing a function named "project_metadata" would be "which metadata? from where?", as there are multiple metadata sources. |
jaraco commentedDec 20, 2021
Oh! I see that pep517already provides this same functionality. Let's get rid of it here. |
Importing an external module is anti-pattern and very unexpected
behavior. Furthermore, the specific builder implementation we are using
will provision an isolated virtual environmnent and perform the build
there, which is unwanted in various scenarious.
Perhaps there was a time this helper was needed, but we can now
remove this in favor of build.util.project_wheel_metadata[1].
[1]https://github.com/pypa/build/blob/82051d509a87124a46f3766134c11fc8aee9b86a/src/build/util.py#L27
Signed-off-by: Filipe Laínslains@riseup.net