Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Switchers handled by docsbuild-scripts.#91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 5 commits intopython:masterfromJulienPalard:switchers
Jun 18, 2020

Conversation

JulienPalard
Copy link
Member

@JulienPalardJulienPalard commentedJun 4, 2020
edited
Loading

closes#90

Tasks:

  • Disable switchers if not disabled cpython side.
  • Install own version ofswitchers.js
  • Makeswitchers.js find the switcher place, even in the absence of span placeholders (cpython could help by adding proper ids, but it's also nice if it works on old branches in which we won't commit the proper ids).
  • Install own version ofindexsidebar.html
  • Template switchers.js sovar all_versions andvar all_languages are not duplicated betweenbuild_docs.py andswitchers.js.
  • Templateindexsidebar.html.
  • Find a better way to insert our switchers.js in the generated HTML pages.

m-aciek and oonid reacted with thumbs up emoji
@JulienPalardJulienPalard requested a review fromzwareJune 4, 2020 22:25
@JulienPalardJulienPalard changed the titleWIP: Switchers handled by docsbuild-scripts.Switchers handled by docsbuild-scripts.Jun 6, 2020
@JulienPalard
Copy link
MemberAuthor

Looks like it works (local builds are usable, tested using./build_docs.py --quick --build-root build_root --www-root www --log-directory logs --group $(id -g) --skip-cache-invalidation as documented in the README, on my laptop, beware it take hours).

The current implementation works without modifications on cpython, so it'll work on old branch we don't want to pollute with this, and we'll be able to clean the master branch later if this PR gets adopted.

Please let me merge this PR myself, so I can closely watch how it goes on docs.pyhon.org immediatly after the merge (as salt will deploy this automatically after merging), to catch potential issues as early as possible, but reviews are appreciated!

oonid reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zwarezwareAwaiting requested review from zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move indexsidebar.html and switchers.js to docsbuild-scripts
1 participant
@JulienPalard

[8]ページ先頭

©2009-2025 Movatter.jp