Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork64
Addtox -e cog to update README tables#313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| {posargs} | ||
| [testenv:cog] | ||
| base_python = python3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can't use 3.14 yet because one transitive dependency is pydantic, which doesn't yet support 3.14.
They added initial support inpydantic/pydantic#11613 and have released analpha, but we're waiting for a final release ofpydantic 2.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a rather heavy dependency for an infrequent task that isn't that much of a hardship:
cog v0.16.6├── attrs v23.2.0├── fastapi v0.115.14│ ├── pydantic v2.11.7│ │ ├── annotated-types v0.7.0│ │ ├── pydantic-core v2.33.2│ │ │ └── typing-extensions v4.15.0│ │ ├── typing-extensions v4.15.0│ │ └── typing-inspection v0.4.1│ │ └── typing-extensions v4.15.0│ ├── starlette v0.46.2│ │ └── anyio v4.10.0│ │ ├── idna v3.10│ │ └── sniffio v1.3.1│ └── typing-extensions v4.15.0├── pydantic v2.11.7 (*)├── pyyaml v6.0.2├── requests v2.32.5│ ├── certifi v2025.8.3│ ├── charset-normalizer v3.4.3│ ├── idna v3.10│ └── urllib3 v2.5.0├── structlog v24.4.0├── typing-extensions v4.15.0└── uvicorn v0.35.0 ├── click v8.2.1 │ └── colorama v0.4.6 └── h11 v0.16.0I'd be fine with using GFM tables (though they're rather verbose in the source), but I don't think we need the other changes in this PR.
A
Good point, I've moved the cog dependency out of |
m-aciek left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice improvement! Looks good to me 👍
I likecog for locality of behaviour.
Also output the tables in GitHub-flavoured Markdown instead of RST, because it's
README.md.And remove the irrelevant Travis CI column, we've not used it for years and
.travis.ymlwas deleted in 2021:python/cpython#30257