python/docsbuild-scriptsPublic

NotificationsYou must be signed in to change notification settings
Fork64
Star78

Run unit tests on three operating systems#285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 4 commits intopython:mainfromhugovk:ci-os

Apr 13, 2025

Merged

Run unit tests on three operating systems#285

hugovk merged 4 commits intopython:mainfromhugovk:ci-os

Apr 13, 2025

Conversation

Copy link

Member

hugovk commentedApr 13, 2025

After removing sed in#272, we should now support Windows in addition to Linux and macOS?

Let's test them to avoid regressions.

Test on three operating systems

dd5c427

Copy link

Member

AA-Turner commentedApr 13, 2025

This doesn't exercise thesed code. If we want to test on multiple OSes then perhaps prefer adding it to the integration test?

Test on three operating systems and Python 3.14

b744fe3

Copy link

MemberAuthor

hugovk commentedApr 13, 2025

Yeah, the integration test was failing when I opened the PR and fixed a couple of minutes later :) Updated, also added 3.14.

There is also value running the unit tests on the other operating systems, we're able to break code there too, whether it's exercises the sed code or not.

pradyunsg approved these changes

Apr 13, 2025

View reviewed changes

ezio-melotti reviewed

Apr 13, 2025

View reviewed changes

.github/workflows/test.yml OutdatedShow resolvedHide resolved

.github/workflows/test.ymlShow resolvedHide resolved

hugovkand others added2 commits

April 13, 2025 16:06

Apply suggestions from code review

f89317b

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

Revert integration test changes

30c5414

Copy link

MemberAuthor

hugovk commentedApr 13, 2025

Integration tests were silently passing even when really failing -- that was fixed in#286 and so they do properly fail when failing now.

And the integration tests were really failing here on Windows ("FileNotFoundError: [WinError 2] The system cannot find the file specified") and macOS ("rsync: --delete-delay: unknown option") and 3.14 ("ERROR: Failed building wheel for pillow"), so for now let's keep this PR just for unit tests after all.