Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Greek translation#248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 6 commits intopython:mainfromlysnikolaou:add-gr-translation
Jun 20, 2025
Merged

Conversation

lysnikolaou
Copy link
Member

  • Add Greek translation (we think we're okay to add this to production since we've done 100% of the prerequisites. If someone could double-check that, it'd be great!
  • Because the iso639 tag for Greek isel, but the more common name isgr, we'd named the repositorypython-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

m-aciek, thepetk, egeakman, hugovk, and StanFromIreland reacted with hooray emoji
@m-aciek
Copy link
Contributor

m-aciek commentedFeb 14, 2025
edited
Loading

  • Because the iso639 tag for Greek is el, but the more common name is gr, we'd named the repository python-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

If we keep the common name, would it be worth to mention allowing exceptions in the repository name in PEP 545?https://peps.python.org/pep-0545/#create-github-repository

Create a repository named “python-docs-{LANGUAGE_TAG}” (IETF language tag, without redundant region subtag, with a dash, and lowercased.) on the Python GitHub organization (SeeRepository For Po Files.), and grant the language coordinator push rights to this repository.

Maybe: ?

Create a repository named “python-docs-{LANGUAGE_TAG}” (without redundant region subtag, with a dash, and lowercased; IETF language tag is recommended) on the Python GitHub organization (SeeRepository For Po Files.), and grant the language coordinator push rights to this repository.

@hugovk
Copy link
Member

Re:https://peps.python.org/pep-0545/#add-translation-to-the-language-switcher

As soon as the translation hits:

  • 100% of bugs.html with proper links to the language repository issue tracker.

https://python-docs-gr.readthedocs.io/el/latest/bugs.html

Looks good.

  • 100% of tutorial.

https://python-docs-gr.readthedocs.io/el/latest/tutorial/index.html

A spot check found a little bit of English inhttps://python-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions

  • 100% of library/functions (builtins).

Looks good, except forabs:https://python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

the translation can be added to the language switcher.

@lysnikolaou
Copy link
MemberAuthor

A spot check found a little bit of English inpython-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions

Hmm, that's odd. It looks like this is implemented inthe po file.

Looks good, except forabs:python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

Again, same thing. It looks like this is implemented inthe po file, but does not appear in the built docs.

Does anyone have an idea on why that might be?

@m-aciek
Copy link
Contributor

@lysnikolaou most probably there's a slight change in the original sources, on 3.13 branch, it would be best to update the files with the latest sources version.

@skpanagiotis
Copy link

Looks good, except for abs:python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

You can see this behavior also in Spanish versionhttps://docs.python.org/es/3.13/library/functions.html#abs

@rffontenelle
Copy link
Contributor

You can see this behavior also in Spanish versionhttps://docs.python.org/es/3.13/library/functions.html#abs

Brazilian Portuguese looks OK, so it is probably just out-of-date source string.

@m-aciek
Copy link
Contributor

m-aciek commentedFeb 14, 2025
edited
Loading

If someone could double-check that, it'd be great!

Checking with the HEAD of 3.13, there seems to be some new content and some differences. Maybe the code snippets blocks affected the numbers 🤔

Doc % make venvDoc % make gettext   python-docs-gr % uv pip install git+https://git.afpy.org/maciek/potodo.git@fix-pot-clipython-docs-gr % potodo --pot ../cpython/Doc/build/gettext --show-finished…- bugs.po                         30 /  31 ( 96.0% translated).…# library (5.07% done)…- functions.po                   413 / 510 ( 80.0% translated).…# tutorial (69.95% done)- appendix.po                     20 /  28 ( 71.0% translated).- appetite.po                     17 /  17 (100.0% translated).- classes.po                     115 / 149 ( 77.0% translated).- controlflow.po                 155 / 223 ( 69.0% translated).- datastructures.po               82 / 125 ( 65.0% translated).- errors.po                       67 /  95 ( 70.0% translated).- floatingpoint.po                43 /  76 ( 56.0% translated).- index.po                         8 /   8 (100.0% translated).- inputoutput.po                  72 / 112 ( 64.0% translated).- interactive.po                   7 /   7 (100.0% translated).- interpreter.po                  25 /  33 ( 75.0% translated).- introduction.po                 76 / 119 ( 63.0% translated).- modules.po                      88 / 117 ( 75.0% translated).- stdlib.po                       47 /  67 ( 70.0% translated).- stdlib2.po                      41 /  65 ( 63.0% translated).- venv.po                         29 /  42 ( 69.0% translated).- whatnow.po                      18 /  18 (100.0% translated).…

For comparison locally looks like 100% indeed:

python-docs-gr % potodo --show-finished --no-cache…- bugs.po                         30 /  30 (100.0% translated).…- functions.po                   461 / 461 (100.0% translated).…# tutorial (100.00% done)- appendix.po                     20 /  20 (100.0% translated).- appetite.po                     17 /  17 (100.0% translated).- classes.po                     119 / 119 (100.0% translated).- controlflow.po                 164 / 164 (100.0% translated).- datastructures.po               90 /  90 (100.0% translated).- errors.po                       69 /  69 (100.0% translated).- floatingpoint.po                48 /  48 (100.0% translated).- index.po                         8 /   8 (100.0% translated).- inputoutput.po                  75 /  75 (100.0% translated).- interactive.po                   7 /   7 (100.0% translated).- interpreter.po                  27 /  27 (100.0% translated).- introduction.po                 79 /  79 (100.0% translated).- modules.po                      89 /  89 (100.0% translated).- stdlib.po                       48 /  48 (100.0% translated).- stdlib2.po                      45 /  45 (100.0% translated).- venv.po                         30 /  30 (100.0% translated).- whatnow.po                      18 /  18 (100.0% translated).…

@AA-Turner
Copy link
Member

Because the iso639 tag for Greek isel, but the more common name isgr, we'd named the repositorypython-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

Unhelpfully, there's divergence betweenISO 3166-1 alpha-2 andISO 639-1. Nevertheless, I think we should stick to ISO 639, the standard for classification of languages, for the avoidance of doubt. I hope this doesn't cause too much trouble.

A

@skpanagiotis
Copy link

We have completed the necessary updates to successfully publish version3.12 ofpython-docs-gr:

  • Updatecpython submodule to the latest version.
  • Synced all .po files with the latest translation for3.12.
  • Applied translation fixes and improvements.

@AA-Turner
Copy link
Member

We have completed the necessary updates to successfully publish version 3.12 of python-docs-gr

Do you have updated numbers for the PEP 545 targets for 3.13 (which is/3/) or 3.13 (/dev/)?

@skpanagiotis
Copy link

Do you have updated numbers for the PEP 545 targets for 3.13 (which is/3/) or 3.13 (/dev/)?

For 3.12

# tutorial (100.00% done)- appendix.po                     24 /  24 (100.0% translated).- appetite.po                     17 /  17 (100.0% translated).- classes.po                     149 / 149 (100.0% translated).- controlflow.po                 223 / 223 (100.0% translated).- datastructures.po              125 / 125 (100.0% translated).- errors.po                       95 /  95 (100.0% translated).- floatingpoint.po                76 /  76 (100.0% translated).- index.po                         8 /   8 (100.0% translated).- inputoutput.po                 112 / 112 (100.0% translated).- interactive.po                   7 /   7 (100.0% translated).- interpreter.po                  33 /  33 (100.0% translated).- introduction.po                119 / 119 (100.0% translated).- modules.po                     117 / 117 (100.0% translated).- stdlib.po                       67 /  67 (100.0% translated).- stdlib2.po                      65 /  65 (100.0% translated).- venv.po                         42 /  42 (100.0% translated).- whatnow.po                      18 /  18 (100.0% translated).------------------------------------------------------------------------------ functions.po                   497 / 497 (100.0% translated).------------------------------------------------------------------------------ bugs.po                         31 /  31 (100.0% translated).

For 3.13

# tutorial (98.16% done)- appendix.po                     24 /  28 ( 85.0% translated).- appetite.po                     17 /  17 (100.0% translated).- classes.po                     149 / 149 (100.0% translated).- controlflow.po                 223 / 223 (100.0% translated).- datastructures.po              125 / 125 (100.0% translated).- errors.po                       83 /  95 ( 87.0% translated), 12 fuzzy.- floatingpoint.po                76 /  76 (100.0% translated).- index.po                         8 /   8 (100.0% translated).- inputoutput.po                 112 / 112 (100.0% translated).- interactive.po                   7 /   7 (100.0% translated).- interpreter.po                  29 /  33 ( 87.0% translated), 4 fuzzy.- introduction.po                118 / 119 ( 99.0% translated), 1 fuzzy.- modules.po                     117 / 117 (100.0% translated).- stdlib.po                       65 /  67 ( 97.0% translated), 2 fuzzy.- stdlib2.po                      64 /  65 ( 98.0% translated), 1 fuzzy.- venv.po                         42 /  42 (100.0% translated).- whatnow.po                      18 /  18 (100.0% translated).-------------------------------------------------------------------------------------------- functions.po                   497 / 497 (100.0% translated).-------------------------------------------------------------------------------------------- bugs.po                         31 /  31 (100.0% translated).

@m-aciek
Copy link
Contributor

There's aconvention to focus on the latest stable Python version. It would be recommended to have a 100% on 3.13 when going live with the switcher. For the time being, we could build the Greek documentation yet without including it in the switcher? (in_prod = false)

AA-Turner reacted with thumbs up emoji

@AA-TurnerAA-Turner changed the titleAdd Greek translation and allow for alternative repo nameAdd Greek translationFeb 27, 2025
@StanFromIreland

This comment was marked as resolved.

@lysnikolaou

This comment was marked as resolved.

@StanFromIreland

This comment was marked as resolved.

@lysnikolaou
Copy link
MemberAuthor

Yes, but it's probably best to merge this when the 3.13 docs are ready either way. We also don't have very much time to work on this, so we've been a bit slow with the port.

AA-Turner reacted with thumbs up emoji

@lysnikolaou
Copy link
MemberAuthor

Folks, this can be merged now, I think.

We've had some slow progress lately, but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14.

hugovk and willingc reacted with hooray emoji

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@StanFromIreland
Copy link
Member

but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14.

Hmm, we don't actually state in PEP 545 which version should meet the requirements. Something we should probably add in future amendments. cc@JulienPalard /@willingc

rffontenelle reacted with eyes emoji

@AA-Turner
Copy link
Member

Custom & practice is the current latest minor version, or 'what/3/ points to'.

StanFromIreland reacted with thumbs up emoji

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • bugs.html: "If you find a bug in the theme ..." is untranslated.
  • functions.html: 'Built-in' appears untranslated, as do the version* directives, and a few reference titles (e.g. 'asynchronous iterator'). I believe (though unsure) that the last of these requires translating the titles of the relevant source articles, so can probably be overlooked. I think the first two should be addressed before being added to the switcher, though.

I've suggested settingin_prod to false, similarly to the recently merged Romanian translation. This will build on the docsbuild infrastructure, and we can revisit the 545 targets hopefully very soon.

A

[languages.el]
name = "Greek"
translated_name = "Ελληνικά"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
in_prod =false

Copy link

@skpanagiotisskpanagiotisJun 20, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We bumped to the latest CPython verion.

  • bugs.html: fixed
  • functions.html: Regardingbuilt-in phrase, it is not untranslated. In some cases throughout the translation project, we intentionally keep the Greek term followed by the English in parentheses. As fo the version* directives I am not entirely sure what the issue is. Some of them render correctly, while others don't.

It's very important for us to publish the translation. This will bring significant benefits such as attracting new contributors, receiving broader feedback and review from end users and motivating current contributors by seeing their work online. 🤗🐍

lysnikolaou, hugovk, and StanFromIreland reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • As fo the version* directives I am not entirely sure what the issue is.

The source strings still requiretranslation in Sphinx (transifex login required). Happy to add any members of the Greek team as language co-ordinators for Greek in Sphinx.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

skpanagiotis and lysnikolaou reacted with heart emoji
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Happy to approve with clarification that some of the remaining English terms are intentional. Thank you!

A

@AA-TurnerAA-Turner merged commita601ce6 intopython:mainJun 20, 2025
10 checks passed
@AA-Turner
Copy link
Member

AA-Turner commentedJun 20, 2025
edited
Loading

The translation is now live:

A

hugovk, rffontenelle, m-aciek, StanFromIreland, willingc, and brianschubert reacted with rocket emoji

@rffontenelle
Copy link
Contributor

Congratulations, Greek team! 👏

willingc and mattwang44 reacted with heart emoji

@StanFromIreland
Copy link
Member

Greek now appears above English in the language switcher, this might annoy people who are used to clicking the first entry, was this intentional?

@rffontenelle
Copy link
Contributor

This might be a consequence of placing languages in the alphabetical order. Should English be an exception and always come first?

@StanFromIreland
Copy link
Member

StanFromIreland commentedJun 23, 2025
edited
Loading

This might be a consequence of placing languages in the alphabetical order.

It is because of the current system, which depends on the order they are read from the file I believe, which is a quite interesting way of doing it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skpanagiotisskpanagiotisskpanagiotis left review comments

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@lysnikolaou@m-aciek@hugovk@skpanagiotis@rffontenelle@AA-Turner@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp