Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork64
Add Greek translation#248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
m-aciek commentedFeb 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
If we keep the common name, would it be worth to mention allowing exceptions in the repository name in PEP 545?https://peps.python.org/pep-0545/#create-github-repository
Maybe: ?
|
hugovk commentedFeb 14, 2025
Re:https://peps.python.org/pep-0545/#add-translation-to-the-language-switcher
https://python-docs-gr.readthedocs.io/el/latest/bugs.html Looks good.
https://python-docs-gr.readthedocs.io/el/latest/tutorial/index.html A spot check found a little bit of English inhttps://python-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions
Looks good, except for
|
lysnikolaou commentedFeb 14, 2025
Hmm, that's odd. It looks like this is implemented inthe po file.
Again, same thing. It looks like this is implemented inthe po file, but does not appear in the built docs. Does anyone have an idea on why that might be? |
m-aciek commentedFeb 14, 2025
@lysnikolaou most probably there's a slight change in the original sources, on 3.13 branch, it would be best to update the files with the latest sources version. |
skpanagiotis commentedFeb 14, 2025
You can see this behavior also in Spanish versionhttps://docs.python.org/es/3.13/library/functions.html#abs |
rffontenelle commentedFeb 14, 2025
Brazilian Portuguese looks OK, so it is probably just out-of-date source string. |
m-aciek commentedFeb 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Checking with the HEAD of 3.13, there seems to be some new content and some differences. Maybe the code snippets blocks affected the numbers 🤔 For comparison locally looks like 100% indeed: |
AA-Turner commentedFeb 15, 2025
Unhelpfully, there's divergence betweenISO 3166-1 alpha-2 andISO 639-1. Nevertheless, I think we should stick to ISO 639, the standard for classification of languages, for the avoidance of doubt. I hope this doesn't cause too much trouble. A |
skpanagiotis commentedFeb 20, 2025
We have completed the necessary updates to successfully publish version
|
AA-Turner commentedFeb 20, 2025
Do you have updated numbers for the PEP 545 targets for 3.13 (which is |
skpanagiotis commentedFeb 20, 2025
For 3.12For 3.13 |
m-aciek commentedFeb 27, 2025
There's aconvention to focus on the latest stable Python version. It would be recommended to have a 100% on 3.13 when going live with the switcher. For the time being, we could build the Greek documentation yet without including it in the switcher? ( |
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
lysnikolaou commentedApr 23, 2025
Yes, but it's probably best to merge this when the 3.13 docs are ready either way. We also don't have very much time to work on this, so we've been a bit slow with the port. |
Uh oh!
There was an error while loading.Please reload this page.
lysnikolaou commentedJun 19, 2025
Folks, this can be merged now, I think. We've had some slow progress lately, but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14. |
StanFromIreland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
StanFromIreland commentedJun 19, 2025
Hmm, we don't actually state in PEP 545 which version should meet the requirements. Something we should probably add in future amendments. cc@JulienPalard /@willingc |
AA-Turner commentedJun 19, 2025
Custom & practice is the current latest minor version, or 'what |
AA-Turner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- bugs.html: "If you find a bug in the theme ..." is untranslated.
- functions.html: 'Built-in' appears untranslated, as do the version* directives, and a few reference titles (e.g. 'asynchronous iterator'). I believe (though unsure) that the last of these requires translating the titles of the relevant source articles, so can probably be overlooked. I think the first two should be addressed before being added to the switcher, though.
I've suggested settingin_prod to false, similarly to the recently merged Romanian translation. This will build on the docsbuild infrastructure, and we can revisit the 545 targets hopefully very soon.
A
| [languages.el] | ||
| name ="Greek" | ||
| translated_name ="Ελληνικά" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| in_prod =false | |
skpanagiotisJun 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We bumped to the latest CPython verion.
bugs.html: fixedfunctions.html: Regardingbuilt-inphrase, it is not untranslated. In some cases throughout the translation project, we intentionally keep the Greek term followed by the English in parentheses. As fo the version* directives I am not entirely sure what the issue is. Some of them render correctly, while others don't.
It's very important for us to publish the translation. This will bring significant benefits such as attracting new contributors, receiving broader feedback and review from end users and motivating current contributors by seeing their work online. 🤗🐍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- As fo the version* directives I am not entirely sure what the issue is.
The source strings still requiretranslation in Sphinx (transifex login required). Happy to add any members of the Greek team as language co-ordinators for Greek in Sphinx.
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
AA-Turner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Happy to approve with clarification that some of the remaining English terms are intentional. Thank you!
A
a601ce6 intopython:mainUh oh!
There was an error while loading.Please reload this page.
AA-Turner commentedJun 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
rffontenelle commentedJun 20, 2025
Congratulations, Greek team! 👏 |
StanFromIreland commentedJun 23, 2025
Greek now appears above English in the language switcher, this might annoy people who are used to clicking the first entry, was this intentional? |
rffontenelle commentedJun 23, 2025
This might be a consequence of placing languages in the alphabetical order. Should English be an exception and always come first? |
StanFromIreland commentedJun 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It is because of the current system, which depends on the order they are read from the file I believe, which is a quite interesting way of doing it. |
el, but the more common name isgr, we'd named the repositorypython-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.