Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork64
Fix Unicode character error building Japanese PDF documents#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
build_docs.py Outdated
| @@ -226,9 +226,11 @@ class Language: | |||
| ) | |||
| PLATEX_DEFAULT = ( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| PLATEX_DEFAULT= ( | |
| LUALATEX_DEFAULT= ( |
Should the variable name be updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I updated in#149.
build_docs.py Outdated
| @@ -257,7 +259,7 @@ class Language: | |||
| Language("fr", "fr", "French", True, XELATEX_WITH_FONTSPEC), | |||
| Language("id", "id", "Indonesian", False, XELATEX_DEFAULT), | |||
| Language("it", "it", "Italian", False, XELATEX_DEFAULT), | |||
| Language("ja", "ja", "Japanese", True, PLATEX_DEFAULT, html_only=True), # See https://github.com/python/python-docs-ja/issues/35 | |||
| Language("ja", "ja", "Japanese", True, PLATEX_DEFAULT, html_only=True), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Language("ja","ja","Japanese",True,PLATEX_DEFAULT,html_only=True), | |
| Language("ja","ja","Japanese",True,LUALATEX_DEFAULT,html_only=True), |
Also later in the file there's a piece of code that prints the platex version, that should be updated to print the lualatex version instead if platex is no longer used anywhere.
If I undertand correctly this PR is stuck with the newlines in the preamble? |
As a「 « "temporary" » 」fix, would running: help? It could be easily added to docsbuild script inside an |
e096f71 to3a75c4dCompareSorry, I had to start over with a new branch. Please take a look at#149. |
With this change, the pdf is fine. But unfortunately, the HTML document will be messed up. I gave up to support U+FFFD with luatex(for now). Please refer#149. |
Fix Unicode character error building Japanese PDF documents.
Seepython/python-docs-ja#31,python/python-docs-ja#35