Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork853
Release cycle chart: show suggestion if JavaScript disabled#997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is an improvement compared to what we have now, but have you considered creating a static image from mermaid at build time (if possible)? This will make it easier to share/embed too.
Seems like that could have a number of issues:
I'm not sure the time, effort and complexity to set up and add to the CI and local workflows is worth it for the tiny proportion of users with JS disabled, but maybe the share/embed use case is more compelling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, FWIW—too bad we have to rely onraw
, but I guess it isn't so bad for the devguide.
I'll have a look into pre-generating an image, it can do SVG or PNG: https://sphinxcontrib-mermaid-demo.readthedocs.io/en/latest/#config-values But as noted it requires installing and running Node.js. We could instead use JavaScript to update the date line for an SVG, but then again we could instead embed the Google chart likehttps://python-release-cycle.glitch.me/ Anyway, let's merge this, thanks for the reviews and suggestions! |
Uh oh!
There was an error while loading.Please reload this page.
Follow on from#988.
Visithttps://devguide.python.org/versions/.
Before: with JavaScript enabled
Before: with JavaScript disabled
After: with JavaScript disabled
Instead, hide chart code and advise the user to enable JS if they wish to see the chart:
Uses the advice athttps://florianbrinkmann.com/en/css-rules-when-javascript-is-disabled-4536/
Demo
https://cpython-devguide--997.org.readthedocs.build/versions/