NotificationsYou must be signed in to change notification settings
Fork931
Star2k

Move .PHONY to each section to avoid copy/paste omissions#972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 1 commit intopython:mainfromhugovk:fix-phony-targets

Oct 21, 2022

Merged

Move .PHONY to each section to avoid copy/paste omissions#972

JelleZijlstra merged 1 commit intopython:mainfromhugovk:fix-phony-targets

Oct 21, 2022

Conversation

Copy link

Member

hugovk commentedOct 21, 2022•
edited
Loading

Similar topython/cpython#98189, the list of phony targets in theMakefile had got out of sync with the commands:clean-venv,ensure-venv andserve were missing.

I expect it will happen again because it's easy to copy and paste a target and not realise/remember to update the list of.PHONY targets at the top of the file.

Let's do as@zware suggested inpython/cpython#98189 (comment) and put each one right next to its target.

We do this atPillow and at work, it helps a lot.

(See alsopython/cpython#98266 to update the CPython docs Makefile andpython/peps#2841 for PEPs.)