NotificationsYou must be signed in to change notification settings
Fork860
Star1.9k

Pin sphinx-lint to fix the CI#955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 1 commit intopython:mainfromhugovk:pin-sphinx-lint

Oct 6, 2022

Merged

Pin sphinx-lint to fix the CI#955

JelleZijlstra merged 1 commit intopython:mainfromhugovk:pin-sphinx-lint

Oct 6, 2022

Conversation

Copy link

Member

hugovk commentedOct 6, 2022•
edited
Loading

Between PR#954 being opened (CI passed) and merged 25 minutes later (CI failed), anew release of sphinx-lint came out with differing checks.

Let's pin it to get the CI green, and I'll open an issue to upgrade and fix the issues.

Pin sphinx-lint

6d37fc9

Copy link

Member

arhadthedev commentedOct 6, 2022

new release of sphinx-lint came out with differing checks.

Or with bugs. From a code diff ofpython/cpython#97962:

sphinx-lint 0.6.2 yields many default role errors due to the new regular expression used for default role detection, so we don't use the version until the errors are fixed.

Copy link

Member

AA-Turner commentedOct 6, 2022

Or with bugs. From a code diff ofpython/cpython#97962:
... the errors are fixed.

I meant the errors in CPython's reStructuredText sources in that comment, I'm assuming the changes in sphinx-lint are correct. I haven't checked either, though.