Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork946
Add a section about how to regenerate the ABI file#903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some typos :)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
pablogsal commentedJun 22, 2022
Thanks for the review@AlexWaygood :) |
| ..code-block::bash | ||
| # In the CPython root: | ||
| $ docker run -v`pwd`:/src -it ubuntu:20.04 bash | ||
| $cd /src | ||
| # Install dependencies to compile CPython | ||
| $ .github/workflows/posix-deps-apt.sh | ||
| # Install dependencies to run the ABI regeneration | ||
| $ apt-get install -yq abigail-tools python3 | ||
| # Ensure CPython is built with all the debugging information | ||
| $export CFLAGS="-g3 -O0" | ||
| # Build Python | ||
| $ ./configure --enable-shared&& make | ||
| # Regenerate the ABI file | ||
| $ make regen-abidump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a long script. Would you object to adding it to the source, and reducing the instructions to just e.g.docker run -v$(pwd):/src -w/src --rm ubuntu:20.04 bash /src/.github/workflows/regen-abidump.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, I think is a good idea. Will prepare a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| with native extensions and other tools that interact with the Python interpreter. | ||
| See the documentation about the:ref:`release candidate<rc>` phase. | ||
| You can regenerate the ABI file by yourself by invoking the ``regen abidump`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
regen-abidump, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will fix this when I update the code block after we mergepython/cpython#94135
No description provided.