Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork856
Reorganize the setup.rst page.#412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few comments explaining what I did + a few questions.
| The core CPython interpreter only needs a C compiler to be built; if | ||
| you get compile errors with a C89 or C99-compliant compiler, please `open a | ||
| bug report <https://bugs.python.org>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This part has been moved below.
| Build dependencies | ||
| ------------------ | ||
| UNIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should include both Linux and macOS.
| UNIX | ||
| ---- | ||
| If you want to install these optional dependencies, consult the | ||
| :ref:`build-dependencies` section below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is the terminology correct here (and elsewhere)?
AFAIU thedependencies, are required to buildextension modules (or simplyextensions). The dependencies can beinstalled (by usingyum/apt/etc) andbuilt (indirectly, bymake).
The section below coversinstalling for Linux, and bothinstalling andbuilding (since different flags are required byconfigure) for macOS.
| _tkinter _uuid readline | ||
| zlib | ||
| To find the necessary bits, look in setup.py in detect_modules() | ||
| for the module's name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added this block to show clearly where the missing extensions are listed, and pointed out that this is expected and should not be considered an error (I've seen people being confused by this message before).
| Clang | ||
| ''''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is now nested under theUNIX section.
| .. _build-dependencies: | ||
| Install dependencies | ||
| ==================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is now a new top-level section, that covers installing dependencies.
Since it also explains how to buiild them for macOS, perhaps the title should be changed toInstall and build dependencies
| ``configure`` and ``make`` (if available for your OS). | ||
| Otherwise the build failed and thus should be fixed (at least with a bug being | ||
| filed on the `issue tracker`_). | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I removed this part because it was duplicated from above. People that reach this point should have already read and know whatmake does.
| ---- | ||
| The basic steps for building Python for development is to configure it and | ||
| then compile it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This part has been moved to the top.
| .. _deps-on-linux: | ||
| Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This used to beUNIX, but it seems to me that it's Linux-specific, since macOS is covered later.
Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@ezio-melotti. This looks great. One small typo. Feel free to merge.
Uh oh!
There was an error while loading.Please reload this page.
* Reorganize the setup.rst page.* Fix typo.
This PR reorganizes the setup.rst page: