Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve label versions triaging#1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
picnixz wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
frompicnixz:feat/workflow/triage-version-labels

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedJul 20, 2025
edited by github-actionsbot
Loading

Some people asked me about how I actually apply my labels while triaging and I think I could actually share my workflow in the devguide instead for future triaging. I especially think that it's not necessary for bugs that span across all active versions to be labelled with the all labels... Ideally, I would have wanted a 3.X+ tag which implies that the bug started appearing in 3.X, and a bot would be able to automate the labels every time a new one is added but this would be a separate issue.

cc@hugovk


📚 Documentation preview 📚:https://cpython-devguide--1613.org.readthedocs.build/

johnslavik reacted with heart emojijohnslavik reacted with rocket emoji
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Comment on lines 131 to 138
- If we are currently in the *beta* period of:samp:`3.{N}.0` and
if a feature was implemented in its *alpha* period but requires a
non-trivial extension (hence a new *feature* issue), this new
feature issue is given the:samp:`3.{N}` label as the latest
version under development would now be:samp:`3.{N+1}.0a1`.

To indicate that the labelling is correct and the extension is
approved, the:gh-label:`triaged` label could also be applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, not sure if we need this? And I'm not sure about the triage label suggestion, it doesn't really say anything more than "issue is accepted by a triager".

ezio-melotti reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, it's for a visual tag. Sometimes I don't remember the issues I've triaged. And if I see an issue with weird label I would say "oh this one could have been mistriaged maybe". But with a triaged label, I know that I don't need to change the labels (same for when I lack a topic-* or a directory for an issue; when there is just "type-bug" it's kind of .. hard to know that there is actually a project associated to the issue; projects can't be seen on the issue page)

The available version labels (with the form:samp:`3.{N}`) are updated
whenever new feature releases are created or retired.

Recommendations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe add a recommendation about whether to keeptype-bug intype-security issues (are they truly redundant?)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that the place for that is beside the type-security doc?

devdanzin reacted with thumbs up emoji
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Comment on lines +128 to +135
- If we are currently in the *beta* period of:samp:`3.{N}.0` and
if a feature was implemented in its *alpha* period but requires a
non-trivial extension (hence a new *feature* issue), this new
feature issue is given the:samp:`3.{N}` label as the latest
version under development would now be:samp:`3.{N+1}.0a1`.

To indicate that the labelling is correct and the extension is
approved, the:gh-label:`triaged` label can also be applied.
Copy link
MemberAuthor

@picnixzpicnixzDec 7, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
-Ifwe are currently in the *beta* period of:samp:`3.{N}.0` and
if a feature was implemented in its *alpha* period but requires a
non-trivial extension (hence a new *feature* issue), this new
feature issue is given the:samp:`3.{N}` label as the latest
version under development would now be:samp:`3.{N+1}.0a1`.
To indicate that the labelling is correct and the extension is
approved, the:gh-label:`triaged` label can also be applied.
-Assume thatwe are currently in the *beta* period of:samp:`3.{N}.0`,
that is, the latest version under development is:samp:`3.{N+1}.0a1`.
If a feature implemented in the *alpha* period of:samp:`3.{N}.0`
requires a non-trivial extension, a *new* feature issue must be
created and be given the:samp:`3.{N}` label.
To indicate that the labelling is correct and the extension is
approved, the:gh-label:`triaged` label can also be applied.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@hugovk Something like this?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note: another acceptable3.N label is when we implement a PEP. It's good to have both feature & 3.N labels at the same time because the PEP is meant to be implemented in that version.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments

@devdanzindevdanzindevdanzin left review comments

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@hugovk@devdanzin@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp