Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update deps and build instructions wrt. libmpdecimal#1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 3 commits intopython:mainfromerlend-aasland:decimal
May 3, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedApr 29, 2024•
edited by github-actionsbot
Loading

@erlend-aaslanderlend-aasland changed the titlemacOS: Recommend building with system installed libmpdecimalUpdate deps and build instructions wrt. libmpdecimalApr 29, 2024
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, although, once we change the configure default for--with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, as long as people didn't care which version of libmpdec is being used.

erlend-aasland reacted with thumbs up emoji
@erlend-aaslanderlend-aasland merged commit5c6a0c1 intopython:mainMay 3, 2024
4 checks passed
@erlend-aaslanderlend-aasland deleted the decimal branchMay 3, 2024 06:33
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedMay 3, 2024•
edited
Loading

Thanks for the review!

LGTM, although, once we change the configure default for--with-system-libmpdec there really wouldn't need to be a separate recipe for 3.13, [...]

Yep.

[...] as long as people didn't care which version of libmpdec is being used.

I don't think the devguide recipe is the place for that user group; for people who care about a particular version of a build dependency, we havehttps://docs.python.org/3/using/configure.html1.

Footnotes

  1. ... and in this particular case, it ishttps://docs.python.org/3.13/using/configure.html#cmdoption-with-system-libmpdec↩

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ned-deilyned-deilyned-deily approved these changes

@zwarezwareAwaiting requested review from zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@erlend-aasland@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp