Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Append a hash ?digest to CSS files for cache-busting#1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromhugovk:add-hash-digest-to-css
Feb 23, 2023

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedFeb 16, 2023
edited
Loading

Similar topython/python-docs-theme#108.

Fix the problems we saw at#1034 (comment) when the CSS file changed but browsers kept the old version cached for 24 hours.

Append a?digest=hash to the end of thepydoctheme.css, computed from the file contents, so when a new CSS file is deployed, the old one is no longer used from the browser cache.

For example:

<link rel="stylesheet" type="text/css" href="_static/devguide_overrides.css?digest=951d6a16b747d96c03796069dbeb516764307ae2" />

This is based on how@pradyunsg's Furo theme does it:

https://github.com/pradyunsg/furo/blob/193643fdb6787501195555244f4a9e953ef544bb/src/furo/__init__.py#L149-L161

Thanks@pradyunsg!

Demo

View the source of pages athttps://cpython-devguide--1054.org.readthedocs.build/.

Furo's css already has a digest, this PR adds it todevguide_overrides.css.

Check the colours load in the EOL chart athttps://cpython-devguide--1054.org.readthedocs.build/versions/

@hugovk
Copy link
MemberAuthor

hugovk commentedFeb 16, 2023
edited
Loading

<link rel="stylesheet" type="text/css" href="_static/_static/devguide_overrides.css?digest=951d6a16b747d96c03796069dbeb516764307ae2" />

Hang on, that double_static isn't right :) Will update!

Edit: fixed!

@hugovkhugovk marked this pull request as draftFebruary 16, 2023 21:02
@hugovkhugovk marked this pull request as ready for reviewFebruary 16, 2023 21:06
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor comment, otherwise LGTM thanks!

…th) tooCo-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(Still LGTM)

hugovk reacted with rocket emoji
@hugovkhugovk merged commitf04b23c intopython:mainFeb 23, 2023
@hugovkhugovk deleted the add-hash-digest-to-css branchFebruary 23, 2023 07:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pradyunsgpradyunsgpradyunsg approved these changes

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@pradyunsg@CAM-Gerlach

[8]ページ先頭

©2009-2025 Movatter.jp