Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork853
Append a hash ?digest to CSS files for cache-busting#1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hugovk commentedFeb 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hang on, that double Edit: fixed! |
706bc8c
toaff9360
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One minor comment, otherwise LGTM thanks!
Uh oh!
There was an error while loading.Please reload this page.
…th) tooCo-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(Still LGTM)
Uh oh!
There was an error while loading.Please reload this page.
Similar topython/python-docs-theme#108.
Fix the problems we saw at#1034 (comment) when the CSS file changed but browsers kept the old version cached for 24 hours.
Append a
?digest=hash
to the end of thepydoctheme.css
, computed from the file contents, so when a new CSS file is deployed, the old one is no longer used from the browser cache.For example:
<link rel="stylesheet" type="text/css" href="_static/devguide_overrides.css?digest=951d6a16b747d96c03796069dbeb516764307ae2" />
This is based on how@pradyunsg's Furo theme does it:
https://github.com/pradyunsg/furo/blob/193643fdb6787501195555244f4a9e953ef544bb/src/furo/__init__.py#L149-L161
Thanks@pradyunsg!
Demo
View the source of pages athttps://cpython-devguide--1054.org.readthedocs.build/.
Furo's css already has a digest, this PR adds it to
devguide_overrides.css
.Check the colours load in the EOL chart athttps://cpython-devguide--1054.org.readthedocs.build/versions/