Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork860
Fix remaining broken links.#1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| :cpy-file:`Doc/library/token-list.inc`. If you change both ``python.gram`` | ||
| and ``Tokens``, run ``make regen-token`` before ``make regen-pegen``. | ||
| changing it, run ``make regen-token`` to regenerate | ||
| :cpy-file:`Include/internal/pycore_token.h`, :cpy-file:`Parser/token.c`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Include/token.h was renamed toInclude/internal/pycore_token.h (the rest is paragraph reflow).
| Then run ``make regen-ast`` to regenerate :cpy-file:`Include/Python-ast.h` | ||
| and :cpy-file:`Python/Python-ast.c`. | ||
| Then run ``make regen-ast`` to regenerate | ||
| :cpy-file:`Include/internal/pycore_ast.h`and :cpy-file:`Python/Python-ast.c`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Include/Python-ast.h was moved toInclude/internal/pycore_ast.h.
| @@ -490,7 +490,7 @@ Finally, you need to introduce the use of the new bytecode. Altering | |||
| places to change. You must add the case for a new opcode into the 'switch' | |||
| statement in the ``stack_effect()`` function in :cpy-file:`Python/compile.c`. | |||
| If the new opcode has a jump target, you will need to update macros and | |||
| 'switch' statements in :cpy-file:`Python/peephole.c`. If it affects a control | |||
| 'switch' statements in :cpy-file:`Python/compile.c`. If it affects a control | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The relevant code was apparently moved intoPython/compile.c inpython/cpython#21517.
| * :cpy-file:`Python/peephole.c`: Optimizes the bytecode. | ||
| * :cpy-file:`Python/pyarena.c`: Implementation of the arena memory manager. | ||
| * :cpy-file:`Python/wordcode_helpers.h`: Helpers for generating bytecode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Both got merged intoPython/compile.c, which is already listed above, so I removed these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One not-directly-related comment, but LGTM at least from a basic source diff inspection and spot-checking the rendered preview
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! 🎄
This PR fixes the remaining broken links andcloses#681.