Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reformat "Important Files" section incompiler.rst#1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ezio-melotti
Copy link
Member

This is a follow-up of#984 that reformats the "Important Files" section incompiler.rst:

I also found another issue with this section:https://devguide.python.org/internals/compiler/#important-files
In addition to the fact that the listed files don't use any markup, the markup used for most of the files seem incorrect (it's a blockquote due to the indentation). A nested list with full paths for all the files and :cpy-file: should be a better alternative.

In the PR I added links to the files using:cpy-file: and reformatted the list.

Before:
image
After:
image

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Couple more deleted files, the rest look okay.

Otherwise looks good, thanks!

@ezio-melotti
Copy link
MemberAuthor

The deleted files are tracked in#1003.

hugovk reacted with thumbs up emoji

@CAM-Gerlach
Copy link
Member

If we're reformatting the whole section like this, maybe worth fixing the lexicographic order too while we're at it?

@ezio-melotti
Copy link
MemberAuthor

I think they are roughly sorted from most to least important.

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM then, thanks@ezio-melotti

ezio-melotti reacted with thumbs up emoji
@ezio-melottiezio-melotti merged commite0fa2bd intopython:mainDec 15, 2022
@ezio-melottiezio-melotti deleted the reformat-compiler-files branchDecember 15, 2022 17:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

Assignees

@ezio-melottiezio-melotti

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ezio-melotti@CAM-Gerlach@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp