Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork47
Document how to update SQLite source dependencies.#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Update the README with the instructions.Use ReST.
README.rst Outdated
| 6. Create the PR, with ``sqlite`` as the base branch. | ||
| Once the PR has been merged, tag the commit as ``sqlite-<full version specified in CPython's PCbuild/get_externals.bat>``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/specified/to be used/
README.rst Outdated
| .. contents:: | ||
| Updating SQLite Source Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can generalize this. Most dependencies (sqlite, bzip2, xz, zlib) follow the same instructions; tcl and tk also follow the same instructions, but have an extra step afterwards that@zooba has to do (updatingcpython-bin-deps); openssl will have a much-expanded step 5. Maybe leave the steps below as is, but note thatsqlite is just used an an example, and the same steps apply to the ones I listed above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks :) so I tried my best at explaining that the other dependencies can be updated in similar fashion. Hope the latest change makes sense..
| <https://github.com/python/cpython-bin-deps/>`_ | ||
| needs to be updated. | ||
| For ``openssl``, step 5 will be more complicated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For each of these, we can link to the source site:
sqlite:https://www.sqlite.org/download.html
bzip2:http://www.bzip.org/downloads.html
xz:https://tukaani.org/xz/
zlib:https://zlib.net/
tcl/tk:https://tcl.tk/software/tcltk/download.html
openssl:https://www.openssl.org/source/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I added a "Download links" section listing the above.
README.rst Outdated
| @@ -19,13 +23,32 @@ Updating SQLite Source Dependencies | |||
| git checkout -b <branch-name>-sqlite upstream/sqlite | |||
| 3. Download SQLite source from ``sqlite.org``. | |||
| 3. Download SQLite source from `sqlite.org <https://www.sqlite.org>`_. | |||
| 4. Unzip it to the checked out branch on step 2. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/checked out branch on/branch checked out in/
README.rst Outdated
| @@ -19,13 +23,32 @@ Updating SQLite Source Dependencies | |||
| git checkout -b <branch-name>-sqlite upstream/sqlite | |||
| 3. Download SQLite source from ``sqlite.org``. | |||
| 3. Download SQLite source from `sqlite.org <https://www.sqlite.org>`_. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should add checking the hash to this step.
Thanks@Mariatta :) |
Update the README with the instructions.
Use ReST.