Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork15
autoconf: Sync config.guess, config.sub with CPython repo, update to latest#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
autoconf/config.sub.patch Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should probably try to upstream this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I submitted a patch upstream:https://lists.gnu.org/archive/html/config-patches/2025-01/msg00000.html
After I did that,@freakboy3742 let me know that he had attempted to upstream the change a couple of times without success:https://lists.gnu.org/archive/html/config-patches/2025-01/msg00001.html. Maybe third time's the charm?
autoconf/Dockerfile Outdated
| ARG CONFIG_GUESS_REV="9428e344e65176b03b69e4bf4ed0d0fc51d4c26f" | ||
| ARG CONFIG_SUB_REV="948ae97ca5703224bd3eada06b7a69f40dd15a02" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Commit9428e344e is from 2021-10-18, and948ae97ca is from 2024-01-01. We should consider using a more recent rev for both of these files. We consider also to just use a commonconfig.git rev; I guess we usually wantconfig.guess andconfig.sub to be sync'ed to the sameconfig.git checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with both of your points. However, I think updating them should be done in a future PR because changing eitherconfig.guess orconfig.sub requires coordination with the cpython repo. I plan on opening additional pull requests to both cpython and this repo once this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No worries, we can safely do so in this PR and make a release. The CPython repo is not affected until we explicitly change the CI and regen-configure script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I updatedconfig.guess andconfig.sub to the latest revision in theconfig.git repo.
Please do not squash this PR's commits when merging (doing so will make it more difficult to understand the history if needed to troubleshoot a problem).
Uh oh!
There was an error while loading.Please reload this page.
Also refresh `config.sub.patch` to match<https://lists.gnu.org/archive/html/config-patches/2025-01/msg00003.html>.
Also, use `set -x` to make troubleshooting easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your continued improvements!
@corona10, are you fine with this? |
I will take a look at it today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!
f624de4 intopython:mainUh oh!
There was an error while loading.Please reload this page.
config.sub.patchis derived from:python/cpython@bee7bb3