Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update patch for ax_c_float_words_bigendian.m4#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedNov 11, 2024•
edited
Loading

The original patch:
autoconf-archive/autoconf-archive#279 broke endianness detection on Emscripten. This was fixed in this followup:autoconf-archive/autoconf-archive#316

We also have worked around the problem by adjustingconfigure.ac in the Python repo to handle this case:
python/cpython#126387
But it's useful for us to use the upstream autoconf-archive detection so that we can be completely sure that the fix works in practice.

cc@erlend-aasland

erlend-aasland reacted with rocket emoji
The original patch:autoconf-archive/autoconf-archive#279broke endianness detection on Emscripten. This was fixed in this followup:autoconf-archive/autoconf-archive#316We also have worked around the problem by adjusting `configure.ac` in the Pythonrepo to handle this case:python/cpython#126387But it's useful for us to use the upstream autoconf-archive detection so that wecan be completely sure that the fix works in practice.
@hoodmane
Copy link
ContributorAuthor

Apologies for the double post (with#33).

erlend-aasland reacted with heart emoji

Copy link
Collaborator

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@erlend-aaslanderlend-aasland merged commite3aa23c intopython:mainNov 11, 2024
@erlend-aasland
Copy link
Collaborator

FTR, I started a new release:https://github.com/python/cpython-devcontainers/actions/runs/11786316759
As soon as the release has been pushed to the registry, we can update the CPython repo.

hoodmane added a commit to hoodmane/cpython that referenced this pull requestNov 12, 2024
…nf-archivePulls in the updated docker container from this PR:python/cpython-devcontainers#34which contains the autoconf-archive PR:autoconf-archive/autoconf-archive#316I removed the workaround from configure.ac, regenerated everything, and manuallytested that the fix works.
hoodmane added a commit to hoodmane/cpython that referenced this pull requestNov 13, 2024
…nf-archivePulls in the updated docker container from this PR:python/cpython-devcontainers#34which contains the autoconf-archive PR:autoconf-archive/autoconf-archive#316I removed the workaround from configure.ac, regenerated everything, and manuallytested that the fix works.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hoodmane@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp