Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork16
feat(#14): import gitlab stuff#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will need Gitlab publishing. Unsure how atm (never used gitlab)
Could maybe base off ofhttps://github.com/docker/build-push-action/blob/4f58ea79222b3b9dc2c8bbdd6debcef730109a75/.github/workflows/.e2e-run.yml,https://github.com/docker/build-push-action/blob/4f58ea79222b3b9dc2c8bbdd6debcef730109a75/.github/workflows/e2e.yml#L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, we will need it, but maybe through manual dispatch? Let's discuss this separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FWIW the docs on GL container registry are here:https://docs.gitlab.com/ee/user/packages/container_registry/index.html
I don't know how you'd upload images built on GitHub to this though.
.github/workflows/ci-images.yml Outdated
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| # - uses: actions/checkout@v4 # I dont think this is needed given git context defaults in build-push-action? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should verify
Uh oh!
There was an error while loading.Please reload this page.
| # Using the image | ||
| We are publishing this Docker image on | ||
| [GitLab](https://gitlab.com/python-devs/ci-images/container_registry). |
JacobCoffeeOct 10, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this and below needs update for GH
changing |
| jobs: | ||
| env: | ||
| GITHUB_REGISTRY: ghcr.io | ||
| GITLAB_REGISTRY: ${{ secrets.GITLAB_REGISTRY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
?
cc@warsaw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you like to update CODEOWENER file to be you,@warsaw and me?
| docker run ${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-test mypy --version | ||
| docker run ${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-test pipx --version | ||
| release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh let's separate the publish process from now on.
Just verify and test will be enough.
| jobs: | ||
| env: | ||
| GITHUB_REGISTRY: ghcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please take a look at how we verify autoconf file at Github Action.
I wish to use similar approach at CI level.
https://github.com/python/cpython-devcontainers/blob/main/.github/workflows/ci.yml
maxking commentedOct 11, 2024
I don't mind helping out with container stuff since I maintain it for mailman anyway. |
What's the status of this PR? |
I have no time or interest in migrating it. It's almost literally zero effort to keep running on GitLab. Maybe the thing to do is to start with mirroring that repo here and having two places where the containers are uploaded (as long as they can be made bit-for-bit identical). I think people are still relying on the GitLab images. |
Uh oh!
There was an error while loading.Please reload this page.
Moves Gitlab files here
Partiallyresolves#14