NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

[3.10] gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles (GH-98459)#99996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

miss-islington merged 1 commit intopython:3.10frommiss-islington:backport-72ec518-3.10

Dec 4, 2022

Merged

[3.10] gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles (GH-98459)#99996

miss-islington merged 1 commit intopython:3.10frommiss-islington:backport-72ec518-3.10

Dec 4, 2022

Conversation

Copy link

Contributor

miss-islington commentedDec 4, 2022•
edited by bedevere-bot
Loading

Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks()
Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you@iritkatriel for pointing it out)
adds a test for a single chained exception that holds a self-loop in itscause andcontext attributes
(cherry picked from commit72ec518)

Co-authored-by: AlexTate0xalextate@gmail.com

Issue:Unittest: self-referencing explicit exception cause results in infinite loop #98458

pythongh-98458: unittest: bugfix for infinite loop while handling cha…

7354ce6

…ined exceptions that contain cycles (pythonGH-98459)* Bugfix addressing infinite loop while handling self-referencing chained exception in TestResult._clean_tracebacks()* Bugfix extended to properly handle exception cycles in _clean_tracebacks. The "seen" set follows the approach used in the TracebackException class (thank you@iritkatriel for pointing it out)* adds a test for a single chained exception that holds a self-loop in its __cause__ and __context__ attributes(cherry picked from commit72ec518)Co-authored-by: AlexTate <0xalextate@gmail.com>

This was referencedDec 4, 2022

Unittest: self-referencing explicit exception cause results in infinite loop#98458

Closed

gh-98458: unittest: bugfix for infinite loop while handling chained exceptions that contain cycles#98459

Merged