Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
gh-99955: standardize return values of functions in assembler and optimizer.#99956
Merged
iritkatriel merged 6 commits intopython:mainfromDec 2, 2022
Merged
gh-99955: standardize return values of functions in assembler and optimizer.#99956iritkatriel merged 6 commits intopython:mainfrom
iritkatriel merged 6 commits intopython:mainfrom
Conversation
Member
markshannon commentedDec 2, 2022
Thanks for doing this. |
markshannon approved these changesDec 2, 2022
Member
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All the functions changed are static, so you can skip the news item.
MemberAuthor
iritkatriel commentedDec 2, 2022
It doesn't cover any of the code-gen function, just optimizer and assembler. code-gen uses 0/1, and the RETURN_IF_FALSE macro, which I think we should either do without or turn into RETURN_IF_ERROR (which would be -1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The individual commit may be easier to review.