Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.11] gh-99845: _PyObject_DictPointer(): fix dictoffset cast#99922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:3.11fromvstinner:obj_dictptr311
Dec 1, 2022
Merged

[3.11] gh-99845: _PyObject_DictPointer(): fix dictoffset cast#99922

vstinner merged 1 commit intopython:3.11fromvstinner:obj_dictptr311
Dec 1, 2022

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedDec 1, 2022•
edited by bedevere-bot
Loading

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit Windows, long is 32-bit whereas Py_ssize_t is 64-bit.

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bitWindows, long is 32-bit whereas Py_ssize_t is 64-bit.
@vstinner
Copy link
MemberAuthor

@serhiy-storchaka: I don't think that it deserves a NEWS entry, since it's unlikely that dictoffset is larger thanLONG_MAX (2^31-1 on 64-bit Windows).

@miss-islington
Copy link
Contributor

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@vstinnervstinner deleted the obj_dictptr311 branchDecember 1, 2022 13:08
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 1, 2022
…H-99922)Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bitWindows, long is 32-bit whereas Py_ssize_t is 64-bit.(cherry picked from commit9707bf2)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-99924 is a backport of this pull request to the3.10 branch.

@vstinner
Copy link
MemberAuthor

@serhiy-storchaka: Merged, thanks for the review.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelDec 1, 2022
miss-islington added a commit that referenced this pull requestDec 1, 2022
Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bitWindows, long is 32-bit whereas Py_ssize_t is 64-bit.(cherry picked from commit9707bf2)Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@miss-islington@bedevere-bot@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp