Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing#99890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 9 commits intopython:mainfromcolorfulappl:clear_freed_pointer
Dec 17, 2022

Conversation

colorfulappl
Copy link
Contributor

@colorfulapplcolorfulappl commentedNov 30, 2022•
edited by bedevere-bot
Loading

In the family of_PyArg_Parse functions, pointers can be passed in as arguments to store the parsed PyArgs.
If a pointer is assigned to newly allocated memory and the memory is freed as a result of an error while parsing the subsequent PyArgs, the pointer should be set to NULL; otherwise, it leaks the freed memory.

erlend-aasland reacted with thumbs up emoji
@colorfulappl
Copy link
ContributorAuthor

colorfulappl commentedNov 30, 2022•
edited
Loading

This fix corresponds to my comment in#99240

If function _PyArg_ParseStack parses failed, assign all the parsed arguments to "NULL" after they are freed, this should be done in _PyArg_ParseStack.

@pythonpython deleted a comment fromnetlifybotDec 14, 2022
@kumaraditya303
Copy link
Contributor

Can you add a test for this?

colorfulappl reacted with thumbs up emoji

@carljmcarljm changed the titlegh-99240: Reset pointer to NULL then the pointed memory is freed in argument parsinggh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsingDec 15, 2022
@kumaraditya303kumaraditya303 self-assigned thisDec 16, 2022
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kumaraditya303kumaraditya303 merged commita6f82f1 intopython:mainDec 17, 2022
@miss-islington
Copy link
Contributor

Thanks@colorfulappl for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@colorfulappl and@kumaraditya303, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker a6f82f1fc68cb24e2d88d35fde4cfb663213a744 3.11

@miss-islington
Copy link
Contributor

Sorry,@colorfulappl and@kumaraditya303, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker a6f82f1fc68cb24e2d88d35fde4cfb663213a744 3.10

@kumaraditya303
Copy link
Contributor

@colorfulappl Can you create the backport PRs? Thanks

colorfulappl reacted with laugh emoji

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull requestDec 17, 2022
…d in argument parsing (python#99890)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 18, 2022
* origin/main: (1306 commits)  CorrectCVE-2020-10735 documentation (python#100306)pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)  "Compound statement" docs: Fix with-statement step indexing (python#100286)pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)  Improve stats presentation for calls. (pythonGH-100274)  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)  Document that zipfile's pwd parameter is a `bytes` object (python#100209)pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)  Fix typo in introduction.rst (python#100266)  ...
@colorfulappl
Copy link
ContributorAuthor

@colorfulappl Can you create the backport PRs?

Sure. I will do this later.

erlend-aasland reacted with heart emoji

carljm added a commit to carljm/cpython that referenced this pull requestDec 19, 2022
* main:pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803)  Docs: Don't upload CI artifacts (python#100330)pythongh-94912: Added marker for non-standard coroutine function detection (python#99247)  CorrectCVE-2020-10735 documentation (python#100306)pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
colorfulappl added a commit to colorfulappl/cpython that referenced this pull requestDec 21, 2022
…is freed in argument parsing (pythonGH-99890)(cherry picked from commitefbb1eb)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-100385 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelDec 21, 2022
colorfulappl added a commit to colorfulappl/cpython that referenced this pull requestDec 21, 2022
…is freed in argument parsing (pythonGH-99890)(cherry picked from commitefbb1eb)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-100386 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelDec 21, 2022
kumaraditya303 added a commit that referenced this pull requestDec 21, 2022
…ed in argument parsing (GH-99890) (#100385)(cherry picked from commitefbb1eb)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
kumaraditya303 added a commit that referenced this pull requestDec 21, 2022
…ed in argument parsing (GH-99890) (#100386)(cherry picked from commitefbb1eb)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
rwgk pushed a commit to rwgk/cpython that referenced this pull requestMar 11, 2023
…d in argument parsing (python#99890)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@kumaraditya303kumaraditya303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@colorfulappl@kumaraditya303@miss-islington@bedevere-bot@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp