Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-89727: Fix os.walk RecursionError on deep trees#99803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
16 commits Select commitHold shift + click to select a range
99f4691
gh-89727: Fix os.walk RecursionError on deep trees
jonburdo3552d49
add unit test to ensure os.walk is not affect by recursion limit
jonburdo3078ea6
move os._walk code to os.walk
jonburdof37bbe8
fix blurb to mention os.walk
jonburdof26a5b8
use deque in os.walk
jonburdo955d21b
Merge branch 'main' into iterative-os-walk
jonburdo8fbfb2e
Merge branch 'main' into iterative-os-walk
jonburdoef46eda
move deque import inside os.walk
jonburdoe261b9f
rename temp_recursion_limit to set_recursion_limit
jonburdo5ec53f7
Merge branch 'main' into iterative-os-walk
jonburdo507b650
switch back to list instead of deque for os.walk stack
jonburdo1c35610
Apply suggestions from code review
jonburdo73138a6
clean up os.walk comments
jonburdo2814cc5
test correct value in test_walk_above_recursion_limit
jonburdo37f3cc7
set islink and join before loop in os.walk
jonburdod9c766c
Merge branch 'main' into iterative-os-walk
jonburdoFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
move os._walk code to os.walk
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit3078ea601feae31baecb36fc2eecfe5e0c19040f
There are no files selected for viewing
8 changes: 3 additions & 5 deletionsLib/os.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.