NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param#99760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 15 commits intopython:mainfromkamilturek:gh-99266

Jan 21, 2023

Merged

gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param#99760

kumaraditya303 merged 15 commits intopython:mainfromkamilturek:gh-99266

Jan 21, 2023

Conversation

Copy link

Contributor

kamilturek commentedNov 24, 2022•
edited by bedevere-bot
Loading

Closes#99266.

The exception fromfd->setfunc is now saved and then restored if the object doesn't have an_as_parameter_.

Issue:ctypes: wrong exception message in docs #99266

bedevere-bot mentioned this pull request

Nov 24, 2022

ctypes: wrong exception message in docs#99266

Closed

bedevere-bot added the awaiting review label

Nov 24, 2022

kamilturek force-pushed thegh-99266 branch 2 times, most recently fromfba818d to6d8d1ceCompare

November 24, 2022 21:00

AlexWaygood changed the title~~gh-99266: Preserve a more detailed exception in from_param~~gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param

Nov 24, 2022

kamilturek force-pushed thegh-99266 branch fromd0dd3de to1be1987Compare

November 24, 2022 21:46

kamilturek marked this pull request as ready for review

November 24, 2022 22:10

eric-wieser approved these changes

Dec 15, 2022

View reviewed changes

Copy link

Contributor

eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM, thanks!

bedevere-bot added awaiting core review and removed awaiting review labels

Dec 15, 2022

kumaraditya303 requested changes

Dec 24, 2022

View reviewed changes

Copy link

Contributor

kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add some tests, the doctests are not run by the buildbots.

bedevere-bot added awaiting changes and removed awaiting core review labels

Dec 24, 2022

Copy link

bedevere-bot commentedDec 24, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.