Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-88564: IDLE - fix 2 Edit menu hotkey displays#99743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
On Mac Cocoa, ^+backspace and ^+space were misdisplayedas ^B and ^S. Replace 'backslash' with '\' everywhere,just as 'slash', for example, is replaced with '/'.On Mac Cocoa, change'space' to 'Space', which then displaysas 'Space' instead of 'S'. ('Space' is also used for theMac-specific Emoji & Symbols entry.)@ronaldoussoren Besides Windows, I tested this on Catalina by editing installed editor.py. Is the space-> Space fix only needed for Cocoa? |
The test failure is hanging for 20 minutes in |
This PR does not work for me. If I manually apply the patch to an installed copy of Python 3.12 IDLE crashes when I try to open the Edit menu ("segmentation fault"). Reverting the patch fixes the crash. The crash report has a stack trace somewhere deep inside system frameworks with Tk on the call stack. The fix is likely only needed for Cocoa, otherwise we'd have reports from other platforms as well. But that's not something I can test, I can only test using the copy of Tk shipped with out installers. |
PR not working right yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've tested this PR with a slight modification to make it work on top of#113513:
diff --git a/Lib/idlelib/editor.py b/Lib/idlelib/editor.pyindex 8bf517d41f..36fde4af73 100644--- a/Lib/idlelib/editor.py+++ b/Lib/idlelib/editor.py@@ -1678,6 +1678,7 @@ def prepstr(s): 'bracketleft': '[', 'bracketright': ']', 'slash': '/',+ 'backslash': '\\', } def get_accelerator(keydefs, eventname):diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.pyindex 8637e8ebf2..60c58d59a3 100644--- a/Lib/idlelib/macosx.py+++ b/Lib/idlelib/macosx.py@@ -263,6 +263,8 @@ def setupApp(root, flist): global _idle_root _idle_root = root if isAquaTk():+ from idlelib import editor+ editor.keynames["space"] = "Space" hideTkConsole(root) overrideRootMenu(root, flist) addOpenEventSupport(root, flist)
That PR makes it an error to callisAquaTk beforemacosx.setupApp is called to avoid problems with Tk Aqua (see that PR for background).
The menu now looks correct, and I've tested that the shortcuts work as well:
My change to the diff should work both with and without#113513. Please move settingidlelib.editor.keynames['space'] tomacosx.setupApp as in the diff above to avoid creating merge conflict when that PR is merged.
When you're done making the requested changes, leave the comment: |
Uh oh!
There was an error while loading.Please reload this page.
On Mac Cocoa, ^+backspace and ^+space were mis-displayed as ^B and ^S. Replace 'backslash' with '' everywhere, just as 'slash', for example, is replaced with '/'. On Mac Cocoa, change 'space' to 'Space', which then displays as 'Space' instead of 'S'. ('Space' is also used for the Mac-specific Emoji & Symbols entry.)
Co-authored byronaldoussoren