Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-85988: Change documentation for sys.float_info.rounds#99675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Change the documentation for sys.float_info.rounds to removereferences to C99 section 5.2.4.2.2 and instead place theavailable values inline.
Newlines were not preserved in generated HTML on previouscommit. I have changes the list to a comma-separated listof values and their meanings.
…cpython into float-info-rounds-documentationMerge upstream branch into local topic branch
Thanks for the PR. A couple of comments: We should keep the "This reflects the value of the system FLT_ROUNDS macro at interpreter startup time" text: there's important information there. In C, The "for floating-point addition" language seems curiously specific (yes, I know it comes directly from the standard). I'd expect the rounding mode to apply to all arithmetic operations (possibly excluding |
Clarify the source of the FLT_ROUNDS value andchange 'floating-point addition' to 'floating-pointarithmetic' to indicate that the rounding modeapplies to all arithmetic operations.
Thank you for the feedback,@mdickinson ! I have made a few changes to address your points. Just let me know if you see anything that I might have overlooked, and I'll be glad to sort it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM too. Thanks!
…nGH-99675)* Change documentation for sys.float_info.roundsChange the documentation for sys.float_info.rounds to removereferences to C99 section 5.2.4.2.2 and instead place theavailable values inline.* Correction to previous documentation changeNewlines were not preserved in generated HTML on previouscommit. I have changes the list to a comma-separated listof values and their meanings.* Clarify source for value of FLT_ROUNDSClarify the source of the FLT_ROUNDS value andchange 'floating-point addition' to 'floating-pointarithmetic' to indicate that the rounding modeapplies to all arithmetic operations.
…nGH-99675)* Change documentation for sys.float_info.roundsChange the documentation for sys.float_info.rounds to removereferences to C99 section 5.2.4.2.2 and instead place theavailable values inline.* Correction to previous documentation changeNewlines were not preserved in generated HTML on previouscommit. I have changes the list to a comma-separated listof values and their meanings.* Clarify source for value of FLT_ROUNDSClarify the source of the FLT_ROUNDS value andchange 'floating-point addition' to 'floating-pointarithmetic' to indicate that the rounding modeapplies to all arithmetic operations.
Uh oh!
There was an error while loading.Please reload this page.
Change the documentation for sys.float_info.rounds to remove references to C99 section 5.2.4.2.2 and instead place the available values inline.