Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99659: Use correct exceptions in sqlite3 bigmem tests#99660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromambv:sqlite3-bigmem-dataerror
Nov 21, 2022

Conversation

ambv
Copy link
Contributor

@ambvambv commentedNov 21, 2022•
edited by bedevere-bot
Loading

The tests in question were added in0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high-M setting in the test runner.

erlend-aasland reacted with thumbs up emoji
The tests in question were added in0eec627 by Serhiy. Apparently,sqlite3 changed exceptions raised in those cases in the mean time butthe tests never ran because they require a high `-M` setting in thetest runner.
@ambvambv added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsNov 21, 2022
@ambvambv merged commit2781ec9 intopython:mainNov 21, 2022
@miss-islington
Copy link
Contributor

Thanks@ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@ambvambv deleted the sqlite3-bigmem-dataerror branchNovember 21, 2022 20:44
@miss-islington
Copy link
Contributor

Sorry,@ambv, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 2781ec9b0e41a62cecc189c22dfc849f9a56927c 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 21, 2022
…nGH-99660)The tests in question were added in0eec627 by Serhiy. Apparently,sqlite3 changed exceptions raised in those cases in the mean time butthe tests never ran because they require a high `-M` setting in thetest runner.(cherry picked from commit2781ec9)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot
Copy link

GH-99666 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 21, 2022
@ambvambv removed the needs backport to 3.10only security fixes labelNov 21, 2022
@ambv
Copy link
ContributorAuthor

Nevermind the 3.10 backport, those test methods don't exist there (and the test file lives inLib/sqlite/test/ on that branch).

erlend-aasland reacted with thumbs up emoji

miss-islington added a commit that referenced this pull requestNov 22, 2022
The tests in question were added in0eec627 by Serhiy. Apparently,sqlite3 changed exceptions raised in those cases in the mean time butthe tests never ran because they require a high `-M` setting in thetest runner.(cherry picked from commit2781ec9)Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambvambv restored the sqlite3-bigmem-dataerror branchDecember 5, 2022 16:30
@ambvambv deleted the sqlite3-bigmem-dataerror branchNovember 1, 2023 13:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@ambvambv

Labels
testsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ambv@miss-islington@bedevere-bot@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp