Could you add docs and tests?

Do we need to specify the pickler and unpickler classes or justdumps() andloads() functions?

I'd also go fordumps andloads instead of pickler/unpickler classes. With a proper definition (e.g. takes a Python object and returns bytes) I think that should make it much more simpler (it is also similar how other pickle-related APIs work outside of the stdlib)

Doc and test have been added.@merwok

The pickler and unpickler classes have been replaced withdumps() andload() functions.@isidentical@serhiy-storchaka

✅ Deploy Preview forpython-cpython-preview canceled.

Should we require the serializer to accept the pickle protocol? It does not make sense for other than pickle formats.

What happens if only serializer or only deserializer are passed?

What happens if only serializer or only deserializer are passed?

elif (serializerisNoneanddeserializerisnotNone)or (deserializerisNoneandserializerisnotNone):raiseShelveError("Serializer and deserializer must be defined together.")

In this case, shelve raises an error.

This seems to have been forgotten over end-of-year break in 2022. Do you want to revive it?

TheBsdDbShelf class needs to be updated as well; its extra functions should usedeserializer rather thanUnpickler

I accidentally deleted my forked repository, so I can't update my old PRs. So I opened a newPR.