Dec 20, 2022 · Nov 20, 2022 · Dec 20, 2022
diff --git a/Lib/http/cookiejar.py b/Lib/http/cookiejar.py
            if self.filename is not None: filename = self.filename
            else: raise ValueError(MISSING_FILENAME_TEXT)

        with os.fdopen(os.open(filename, os.O_CREAT | os.O_WRONLY, 0o600), 'w') as f:
        with os.fdopen(
            os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600),
            'w',
        ) as f:
            # There really isn't an LWP Cookies 2.0 format, but this indicates
            # that there is extra information in here (domain_dot and
            # port_spec) while still being compatible with libwww-perl, I hope.
            if self.filename is not None: filename = self.filename
            else: raise ValueError(MISSING_FILENAME_TEXT)

        with os.fdopen(os.open(filename, os.O_CREAT | os.O_WRONLY, 0o600), 'w') as f:
        with os.fdopen(
            os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600),
            'w',
        ) as f:
            f.write(NETSCAPE_HEADER_TEXT)
            now = time.time()
            for cookie in self:
diff --git a/Lib/test/test_http_cookiejar.py b/Lib/test/test_http_cookiejar.py
        finally:
            os_helper.unlink(filename)

    @unittest.skipIf(mswindows, "windows file permissions are incompatible with file modes")
    @os_helper.skip_unless_working_chmod
    def test_cookie_files_are_truncated(self):
        filename = os_helper.TESTFN
        for cookiejar_class in (LWPCookieJar, MozillaCookieJar):
            c = cookiejar_class(filename)

            req = urllib.request.Request("http://www.acme.com/")
            headers = ["Set-Cookie: pll_lang=en; Max-Age=31536000; path=/"]
            res = FakeResponse(headers, "http://www.acme.com/")
            c.extract_cookies(res, req)
            self.assertEqual(len(c), 1)

            try:
                # Save the first version with contents:
                c.save()
                # Now, clear cookies and re-save:
                c.clear()
                c.save()
                # Check that file was truncated:
                c.load()
            finally:
                os_helper.unlink(filename)

            self.assertEqual(len(c), 0)

    def test_bad_magic(self):
        # OSErrors (eg. file doesn't exist) are allowed to propagate
        filename = os_helper.TESTFN
diff --git a/Misc/NEWS.d/next/Library/2022-11-20-11-59-54.gh-issue-99576.ZD7jU6.rst b/Misc/NEWS.d/next/Library/2022-11-20-11-59-54.gh-issue-99576.ZD7jU6.rst
 Fix ``.save()`` method for ``LWPCookieJar`` and ``MozillaCookieJar``: saved
 file was not truncated on repeated save.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1890,7 +1890,10 @@ def save(self, filename=None, ignore_discard=False, ignore_expires=False):
		if self.filename is not None: filename = self.filename
		else: raise ValueError(MISSING_FILENAME_TEXT)

		with os.fdopen(os.open(filename, os.O_CREAT \| os.O_WRONLY, 0o600), 'w') as f:
		with os.fdopen(
		os.open(filename, os.O_CREAT \| os.O_WRONLY \| os.O_TRUNC, 0o600),
		'w',
		) as f:
		# There really isn't an LWP Cookies 2.0 format, but this indicates
		# that there is extra information in here (domain_dot and
		# port_spec) while still being compatible with libwww-perl, I hope.
Expand DownExpand Up		@@ -2086,7 +2089,10 @@ def save(self, filename=None, ignore_discard=False, ignore_expires=False):
		if self.filename is not None: filename = self.filename
		else: raise ValueError(MISSING_FILENAME_TEXT)

		with os.fdopen(os.open(filename, os.O_CREAT \| os.O_WRONLY, 0o600), 'w') as f:
		with os.fdopen(
		os.open(filename, os.O_CREAT \| os.O_WRONLY \| os.O_TRUNC, 0o600),
		'w',
		) as f:
		f.write(NETSCAPE_HEADER_TEXT)
		now = time.time()
		for cookie in self:
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -397,6 +397,32 @@ def test_mozilla_filepermissions(self):
		finally:
		os_helper.unlink(filename)

		@unittest.skipIf(mswindows, "windows file permissions are incompatible with file modes")
		@os_helper.skip_unless_working_chmod
		def test_cookie_files_are_truncated(self):
		filename = os_helper.TESTFN
		for cookiejar_class in (LWPCookieJar, MozillaCookieJar):
		c = cookiejar_class(filename)

		req = urllib.request.Request("http://www.acme.com/")
		headers = ["Set-Cookie: pll_lang=en; Max-Age=31536000; path=/"]
		res = FakeResponse(headers, "http://www.acme.com/")
		c.extract_cookies(res, req)
		self.assertEqual(len(c), 1)

		try:
		# Save the first version with contents:
		c.save()
		# Now, clear cookies and re-save:
		c.clear()
		c.save()
		# Check that file was truncated:
		c.load()
		finally:
		os_helper.unlink(filename)

		self.assertEqual(len(c), 0)

		def test_bad_magic(self):
		# OSErrors (eg. file doesn't exist) are allowed to propagate
		filename = os_helper.TESTFN
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix ``.save()`` method for ``LWPCookieJar`` and ``MozillaCookieJar``: saved
		file was not truncated on repeated save.