Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-99606: consistent empty f-string bytecode#99608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Note on "remove redundancy": in `compiler_joined_str()`, replace all further references of `asdl_seq_LEN(e->v.JoinedStr.values)` with `value_count`.
thatbirdguythatuknownot commentedDec 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Other PR (#112407) got merged. |
Sorry, I didn't notice your PR before I made mine. I should have looked more carefully! |
It's alright, I think the other one is a better approach anyway. Besides, this one doesn't have tests. |
Uh oh!
There was an error while loading.Please reload this page.
In
compiler_joined_str(), handle empty f-strings by merging logic with the firstifstatement and replace all further references ofasdl_seq_LEN(e->v.JoinedStr.values)withvalue_count.