Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99593: Add tests for Unicode C API#99594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedNov 19, 2022•
edited by bedevere-bot
Loading

@serhiy-storchaka
Copy link
MemberAuthor

I have found a bug during testing. I'll extract it into a separate issue later.

I'll write the remaining tests after some rest.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you want me to review this PR, can you please split it into smaller PR? Like start with a shorter PR, wait until it's merged, then move to the next one.

@serhiy-storchaka
Copy link
MemberAuthor

I'll split it on three parts:

  • higher-level C API corresponding tostr methods
  • lower-level C API
  • codecs

@vstinner
Copy link
Member

I'll split it on three parts:

Are you talking about creating 3 PRs modifying the same files, or do you consider to have separated C and Python files for "higher-level C API corresponding to str methods"? Maybe it's just fine to put most "unicode" tests in "unicode.c" and "unicode.py" tests.

@serhiy-storchaka
Copy link
MemberAuthor

As you suggested, I'll add codecs tests in a separate Python file. The rest of tests will be inLib/test/test_capi/test_unicode.py.

All wrappers will be defined inModules/_testcapi/unicode.c. It is nice that it was separated from_testcapi.c.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commentedNov 23, 2022•
edited by erlend-aasland
Loading

@hugovkhugovk removed the needs backport to 3.10only security fixes labelApr 7, 2023
@erlend-aasland
Copy link
Contributor

Since part 1 and 2 are merged, and part 3 (gh-104728) is in the queue, I recon we can close this :)

@serhiy-storchakaserhiy-storchaka deleted the test-unicode-capi3 branchJune 29, 2023 10:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@encukouencukouAwaiting requested review from encukou

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@serhiy-storchaka@vstinner@erlend-aasland@hugovk@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp