Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99582: freeze zipimport into _bootstrap_python#99583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kkpattern
Copy link
Contributor

@kkpatternkkpattern commentedNov 18, 2022•
edited by bedevere-bot
Loading

When build python with other build systems, we may need _bootstrap_python to import modules from zipped stdlib.

I have tested this PR on Windows, Linux, and macOS. But since this change will affect the building process, I suggest we also test it with buildbot before merge.

@kumaraditya303kumaraditya303 self-assigned thisNov 28, 2022
@kumaraditya303kumaraditya303 added the buildThe build process and cross-build labelNov 28, 2022
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

kkpatternand others added2 commitsNovember 29, 2022 01:44
When build python with other build systems, we may need_bootstrap_python to import modules from zipped stdlib.
…e-99582.wvOBVy.rstCo-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit1eda26d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 29, 2022
@kumaraditya303kumaraditya303 merged commit228c92e intopython:mainDec 10, 2022
@kumaraditya303
Copy link
Contributor

Thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@kumaraditya303kumaraditya303

Labels
buildThe build process and cross-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kkpattern@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp