Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times#99543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 3 commits intopython:mainfromzooba:gh-99377
Nov 17, 2022

Conversation

zooba
Copy link
Member

@zoobazooba commentedNov 16, 2022•
edited by bedevere-bot
Loading

This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.

… actually been set.This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@zooba for commitc732ecc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 16, 2022
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I'm surprised_PyThreadState_SetCurrent() can leave itNULL though. Something seems fishy there.

@zooba
Copy link
MemberAuthor

This hasn't done it. Going to revert most of the change (I'll leave the_thread event in there, just not the ThreadState ones)

@ericsnowcurrently
Copy link
Member

FYI, I'm double-checking that that PR was the culprit:gh-99545.

@ericsnowcurrently
Copy link
Member

Looks like a full revert passes all buildbots (actually, 7 still running), so it seems like we're right that the original PR is the source of the failures.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@sobolevn
Copy link
Member

This also closes#99544

@zoobazooba changed the titlegh-99377: Prevent raising audit event when thread state has not actually been set.gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these timesNov 16, 2022
@AlexWaygoodAlexWaygood linked an issueNov 16, 2022 that may beclosed by this pull request
@zoobazooba merged commit5fdd49d intopython:mainNov 17, 2022
@zoobazooba deleted the gh-99377 branchNovember 17, 2022 00:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildbots are crashing after #99378
4 participants
@zooba@bedevere-bot@ericsnowcurrently@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp