NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373)#99493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ambv merged 2 commits intopython:3.9fromzooba:gh-87604-3.9

Nov 21, 2022

Merged

[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373)#99493

ambv merged 2 commits intopython:3.9fromzooba:gh-87604-3.9

Nov 21, 2022

Conversation

Copy link

Member

zooba commentedNov 14, 2022•
edited by bedevere-bot
Loading

Issue:[doc] sys.addaudithook() documentation should be more explicit on its limitations #87604

pythongh-87604: Avoid publishing list of active per-interpreter audit…

3a5f9f0

… hooks via the gc module (pythonGH-99373)

bedevere-bot added the awaiting core review label

Nov 14, 2022

bedevere-bot mentioned this pull request

Nov 14, 2022

[doc] sys.addaudithook() documentation should be more explicit on its limitations#87604

Closed

zooba added the needs backport to 3.8 label

Nov 14, 2022

zooba changed the title~~gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373)~~[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373)

Nov 14, 2022

bedevere-bot mentioned this pull request

Nov 14, 2022

gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module#99373

Merged

bedevere-bot added the type-securityA security issue label

Nov 14, 2022

Fix variable name

9fd2fae

Copy link

MemberAuthor

zooba commentedNov 14, 2022•
edited
Loading

@pablogsal We agreed (on the original PR) that this is a minor, but harmless change. I'm intending to backport it into my patchset for 3.8 and 3.9 builds at work, so figured that means it's worth backporting for everyone. But your call, of course.

Copy link

Member

pablogsal commentedNov 16, 2022

I am +1 backporting this but maybe you want to check with@ambv instead for 3.9 and 3.8?

Copy link

Member

pablogsal commentedNov 16, 2022

I am assuming 3.10 has the fix already no?

Copy link

MemberAuthor

zooba commentedNov 16, 2022

🤦 Yes,@ambv, what are your thoughts?

It's already in 3.10 in#99492. The backport couldn't be done automatically to 3.9, which is why it's not linked yet

Copy link

Contributor

ambv commentedNov 21, 2022

I'm +1 to backport to 3.9 and 3.8.

ambv merged commit7b98207 intopython:3.9

Nov 21, 2022

Copy link

Contributor

miss-islington commentedNov 21, 2022

Thanks@zooba for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

Nov 21, 2022

Copy link

Contributor

miss-islington commentedNov 21, 2022

Sorry@zooba and@ambv, I had trouble checking out the3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 7b98207aa46bd637d07a7c4a84e998726b74acde 3.8