Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-99370: fix test_zippath_from_non_installed_posix#99483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 3 commits intopython:mainfromkkpattern:fix_test_venv_shared
Nov 15, 2022

Conversation

kkpattern
Copy link
Contributor

@kkpatternkkpattern commentedNov 14, 2022
edited by bedevere-bot
Loading

When build with shared enabled, we need to setLD_LIBRARY_PATH for the non-installed python environment in
test_zippath_from_non_installed_posix so that the python binary and find and link the libpython.so.

When build with shared enabled, we need to set `LD_LIBRARY_PATH`for the non-installed python environment intest_zippath_from_non_installed_posix so that the python binaryand find and link the libpython.so.
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@zware for commit7082899 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 14, 2022
@zware
Copy link
Member

Looks like we still have a failure:https://buildbot.python.org/all/#builders/713/builds/829. There may be others yet to be reported.

@kkpattern
Copy link
ContributorAuthor

Yeah. Looks like the stdlib files are not copied into the non-installed python so it can't be correctly initialized. I'm trying to figure out why. Intest_zippath_from_non_installed_posix, I try to create a non-installed python environment to test venv created from it. In order for the non-installed python to find stdlib, I iterate through thesys.path and check the zip landmark and the os.py landmark to copy the stdlib files.

@kkpattern
Copy link
ContributorAuthor

SeemAMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR829 build cpython out of source tree. I will try to replicate the build locally.

@kkpattern
Copy link
ContributorAuthor

So it's because theplatlibdir is configured tolib64. I will change the lib directory name according tosys.platlibdir.

Python can be built with platlibdir configured to "lib64". Usesys.platlibdir instead of "lib" intest_zippath_from_non_installed_posix.
@zwarezware added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 14, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@zware for commitde73f73 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 14, 2022
@zoobazooba merged commit1df0752 intopython:mainNov 15, 2022
@zoobazooba added the needs backport to 3.11only security fixes labelNov 15, 2022
@miss-islington
Copy link
Contributor

Thanks@kkpattern for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99498 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 15, 2022
…9483)When build with shared enabled, we need to set `LD_LIBRARY_PATH`for the non-installed python environment intest_zippath_from_non_installed_posix so that the python binaryand find and link the libpython.so.(cherry picked from commit1df0752)Co-authored-by: Kai Zhang <kylerzhang11@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelNov 15, 2022
miss-islington added a commit that referenced this pull requestNov 15, 2022
When build with shared enabled, we need to set `LD_LIBRARY_PATH`for the non-installed python environment intest_zippath_from_non_installed_posix so that the python binaryand find and link the libpython.so.(cherry picked from commit1df0752)Co-authored-by: Kai Zhang <kylerzhang11@gmail.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull requestNov 16, 2022
* main: (8272 commits)  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)  Post 3.12.0a2pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@kkpattern@bedevere-bot@zware@miss-islington@zooba

[8]ページ先頭

©2009-2025 Movatter.jp